[rfc][icedtea-web] Fix resource loading in CodebaseManifestEntry reproducers

Jiri Vanek jvanek at redhat.com
Mon Mar 16 15:50:47 UTC 2015


On 03/16/2015 03:29 PM, Jie Kang wrote:
> Hello,
>
> The CodebaseManifestEntry reproducers were failing due to NPE in getting the Message.properties resource. This patch fixes that. The tests no longer fail with NPE when manifest checks are enabled.
>
> However, for the most part, manifest checks are disabled when running reproducers in order to prevent popup dialogs from causing them to fail. I think ldracz is working on a fix to allow us to test with them enabled/disabled per-test/per-reproducer. This fix should be applied here when able.
>
> Also, the tests still have some errors unrelated to this resource loading which will be addressed in a separate patch.
>
> Thoughts?
>
>
> Regards,
>


Looks ok. Please, before push, ensure that it is working both in IDE and from commandline. In past 
there were divergences. From commandline very often direct call to getSystemClasloader was necessary.


Any working change on this line is ok to go.
Thanx!

J.


More information about the distro-pkg-dev mailing list