[rfc][icedtea-web] fix TrustedOnlyAttributeTest by enabling Trusted Only check

Jiri Vanek jvanek at redhat.com
Fri Mar 27 12:50:43 UTC 2015


On 03/26/2015 07:58 PM, Lukasz Dracz wrote:
> Hello,
>
> This patch fixes TrustedOnlyAttributeTest by changing the deployment.manifest.attributes.check to TRUSTED in BeforeClass and back to its previous value in AfterClass. The fix is similar to how SignedAppletManifestSpecifiesSandbox needed this done with PERMISSIONS. I had tracked the patch that "broke" the tests to http://icedtea.classpath.org/hg/icedtea-web/rev/26b5ec24ec08.
>
> The tests were written before the deployment.manifest.attributes.check was added. The tests expect checkTrustedOnlyAttribute() to be run, but since most of the time when reproducers are run the deployment.manifest.attributes.check is set to false, it would fail. The tests pass at the moment but only if run with deployment.manifest.attributes.check is set with TRUSTED in the combination or with only ALL. This patch makes it so tests can be run with deployment.manifest.attributes.check set to NONE as they typically are and still pass.
>
> Thank you,
> Lukasz Dracz
>
Hi!

Looks good. My apologies, I had pushed for you, to have this fix in todays test run. Hope it is ok.

Thank you!

   J.


More information about the distro-pkg-dev mailing list