[rfc][icedtea-web] change FILElogs contnet

[Jiri Vanek]

On 03/30/2015 05:39 PM, Jie Kang wrote:
>
>
> ----- Original Message -----
>>>>
>>>> I don't have the working coppy of this anymore...
>>>
>>> Ff you plan to push it won't you get a copy of this?
>>
>> Yah. i really donty.
>
> Wait... so you don't want to push this? Or you do (since you sent it to list with [rfc])? I am confused now :\
Oh today is some bad sun shining or I dont know :)

I really dont have the physical diff.
And I really do wont to push it :)
>
>>
>> I found it during much bigger patch, exported diff, copied those two lines to
>> this email, and
>> reverted so it will not spam the bigger patch :(
>>>
>>> You say:
>>>
>>>>>> Removed (may be set to different location by you)
>>>
>>> but then you say:
>>>
>>>>>> Now the output looks like:
>>
>> yes now, like "before the patch"
>>>>>>      - (may be set to different location by you) contains file log files
>>>>>>      (if
>>>>>>      enabled).
>>>
>>> This still has: (may be set to different location by you)
>>>
>>> So is it removed or not?
>>
>> After the changeset, the output will be correct:
>>
>> - contains file log files (if enabled).
>>
>> Sorry for confusion with "now it looks like"
>
> I see. Okay, thanks for clearing it up.
>
> AFAIK you are able to change the log directory using itweb-settings or manually editing deployment.properties file with: deployment.user.logdir value + deployment.log.file=true. Is this not true any more for HEAD?

Yes it is true, but deployment.log.file about enabling/disabling it
deployment.user.logdir is specifing the location where it will be saved if  it is enabled.

And yes, it is also correct on head. The docs are clear bout it "Controled by 
deployment.user.logdir" as is on each line of setupable file.
>
> s/file log files/log files
  sure, this may be included.

>
> or how about something like:
>
> "Directory containing log files, itw-cplugin-date_time.log for native part of plugin, itw-javantx-date_time.log for everything else."

ok.

>
>
> Regards,
>
>
>>
>> J.
>>>
>>> If you had a diff file then it would be obvious.
>>>
>>>
>>> Regards,
>>>
>>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>>>
>>>>>> As Controlled by deployment.user.logdir is geenrated automatically, the
>>>>>> preamble had no effect.
>>>>>>
>>>>>> Ok for head?
>>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>>
>>>>>>
>>>>>> J.
>>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>>
>