[rfc][icedtea-web] manager for desktop integration

Fri Nov 6 13:46:48 UTC 2015

On 11/02/2015 02:37 PM, Jiri Vanek wrote:
> On 11/02/2015 09:12 AM, Jacob Wisor wrote:
>> On 10/29/2015 at 05:06 PM Jiri Vanek wrote:
...
>
> I already did. And it appeared to be much less usefull that I hoped.
> Only iomageio worked with this spi. Nothing *inside* jdk using *it's own decoders* - eg default
> toolkit => nothing using those methods (eg nothing using default toolkit) had benefit from thi sspi.
> eg nothing in swing (eg jtextpane ot other <html> capable components like jlabel and so...) had
> benefit from it.
>
> So original question ion "what now" was  - does it have sense to bother with spi at all?
>
> J.
> [1] http://mail.openjdk.java.net/pipermail/awt-dev/2015-October/010255.html

So you were right. Internal bmpreader canbe used to read actual color bits of ico images.

So there is cusotm image reader, based on custom parsing of header and then - ty to read ncontent as 
png, or fake bmp infoHEader and read it as bmp.

On top of this reader is  build spi provider and reader whch is registered for ITW.

I think (did not yet tried) that it is registered to ITW's thread group only, so applets/javaws 
appswil not able to use it anyway. But it is subject of another changsets (including unttests for 
his reader)

i tested it wit all variants gimp can prduce (bmp x pngx(0,2,4,8,16,32,256) colors.Also I tested it 
with quite a lot of corrupted icons I found on web (like mixed pngs and bitmpas or not square sizes, 
incorrect usages of 0x256 and so on)

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icoReaderAndSpiProvider.diff
Type: text/x-patch
Size: 28053 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20151106/c10f2caf/icoReaderAndSpiProvider-0001.diff>