[rfc][icedtea-web] add switch to trim main-class attribute

[Jiri Vanek]

On 11/06/2015 04:03 PM, Andrew Azores wrote:
> On 06/11/15 09:41 AM, Jiri Vanek wrote:
>> Hello!
>>
>>
>> I'm bugged at elast once per month  last half a year  "oracle can parse
>> this jnlp, itw can not". The cause is always same - white char on start
>> or end of amin-class attribute value.
>>
>> This patch is for head, and is adding warning when white-char is there
>> and is adding new Xtrimmainclass javaws switch, which will allow
>> trimming (if there si whitechat).
>>
>> I would like to backport to 1.6 the refactoring of Parser to allow print
>> this warning also there (so no new switch for 1.6)
>>
>>
>> I recall several discussions about triming by default, and the resutl
>> was always no. If mood changes I'm 60:40 ok to change this for head.
>>
>> Thoughts?
>>
>>
>>   J.
>>
>>
>> unittests and reproducers on way as separate changeset...
>
> Code looks fine to me, just one thing:
>
>> +    private static final Pattern enyWhiteSpace = Pattern.compile("\\s");
>
> s/enyWhiteSpace/anyWhiteSpace/g
>
> FWIW I do think the better approach is to offer this capability but leave it off by default (as you've done here).
>


Thank you!


Jacob brought up the question of trimming by default.

May you pledge some thoghts to that thread?


J.