[rfc][icedtea-web] add switch to trim main-class attribute

[Jiri Vanek]

On 11/09/2015 05:17 PM, Jacob Wisor wrote:
> On 11/07/2015 at 03:32 PM Jacob Wisor wrote:
>> On 11/07/2015 at 03:19 PM Jacob Wisor wrote:
>>> On 11/07/2015 at 09:25 AM Jiri Vanek wrote:
>>>> On 11/06/2015 10:35 PM, Jacob Wisor wrote:
>>>>> On 11/06/2015 at 03:41 PM Jiri Vanek wrote:
>>>> YES!  Only leading and trailing  whitesapces  before and after value of
>>>> mian-class attribute.
>>>>> Or, is it about the "Main-Class" attribute name? Could you please give some
>>>>> examples?
>>>> no!
>>>>
>>>> main-class="some.class" => String "some.class" will be used in ITW (now
>>>> identical  "some.class" is)
>>>
>>> Should get accepted.
>>>
>>>> main-class="so me.cl ass" => String "some.class" will be used in ITW (now
>>>> identical "so me.cla ss" is)
>>>
>>> Must NOT get accepted.
>>>
>>>> main-class="   some.class" => String "some.class" will be used in ITW (now  "
>>>> some.class" is)
>>>
>>> Should get accepted.
>>>
>>>> main-class=" some.class    " => String "some.class" will be used in ITW (now "
>>>> some.class    " is)
>>>
>>> Should get accepted.
>>>
>>>> main-class="some.class " => String "some.class" will be used in ITW (now
>>>> "some.class " is)
>>>
>>> Should get accepted.
>>>
>>>> main-class="  so me.cl ass " => String "so me.cla ss" will be used in ITW (now "
>>>> so me.cla ss " is)
>>>
>>> Must NOT get accepted.
>>
>> Another case came just to my mind:
>>
>> main-class="some .class . Name"
>>
>> This /may/ get accepted if the dot character (. FULL STOP U+002E) has the
>> semantics of an operator in fully qualified class names according to the Java
>> Specification. But I am not sure about that. You'd have to look deeper into it.
>
> I could not find anything special about the dot character except that it is the reference operator
> in Java programming language statements.
> Hence, the compiler accepts this in statements:
>
> javax.
>   imageio . stream    .
> FileImageInputStream
>
> So I guess, IcedTea-Web should accept white spaces around valid identifiers and/or the dot
> characters too, wherever it handles Java identifiers, package or fully qualified class names.
>
> Regards,
>
> Jacob

Here we go, rund two.
1.6?


Thnak you all!


J.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: trimMainClass2.patch
Type: text/x-patch
Size: 14966 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20151119/801649b8/trimMainClass2-0001.patch>