[rfc][icedtea-web] replacing log-based file logger by writer

Jiri Vanek jvanek at redhat.com
Fri Oct 16 12:38:53 UTC 2015


As hinted in

[rfc][icedtea-web] pre-review - accidental logging tweeking:
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2015-October/033732.html
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2015-October/033741.html
and
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2015-October/033742.html

This is fixing rare deadlock when application run inside itw run its custom logger.

I was thinking also baout another solutions, but then I moved them out - wh do itw needs 
java.util.logging anyway? It do not...
I kept the possibility to enable current LogBased file logger just for case... I think it will go 
away in future anyway.

I also moved the SinglleStreamLogger to implements autocloseable instead of its own close().
It was surprisingly only two linner patch, so I included it here, But I will push it as separate 
chnageset.


I'm thinking about backporting this to 1.6, with only difference - the legacy loggerbasedlog will be 
by default on, and writer-based one the backup one - so people hitting this error via elluminate 
will have possibility to switch.

Also - when unittests are run in verbose mode, they also can deadlock. This had fixed it too. Aslo 
they can be used as performance meassurement, and - surprisingly - the writer-based run was 
faster... (note on note, running the testsuites on verbose+filelog is  *no* recommanded way to run 
them :) )


J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: useWriterBasedFileLogByDefaultRatherThenLogBasedFileLog.patch
Type: text/x-patch
Size: 39554 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20151016/05f939ad/useWriterBasedFileLogByDefaultRatherThenLogBasedFileLog-0001.patch>


More information about the distro-pkg-dev mailing list