OpenJDK 7u91 and IcedTea

[Andrew Hughes]

----- Original Message -----
> Andrew,
> 
> Thanks for the hard work. I highly appreciate it. =)
> 
> I apologize for the delay, I was able to package 2.6.2pre02 only
> yesterday. After few successful builds on AMD64 and PPC64LE I let the
> PPA build it overnight. It failed to build on ARM64 (AARCH64) for
> Zero.
> 

Thanks for the testing. Very much appreciated!

> A snippet of the build log follows bellow, I also saved it on pastebin
> @ https://paste.fedoraproject.org/282393/18046144/
> 
> 
> 
> Original:
> https://launchpad.net/~tdaitx/+archive/ubuntu/openjdk/+build/8169173/+files/buildlog_ubuntu-wily-arm64.openjdk-7_7u91-2.6.2-0ubuntu1%7Epre02%7E20151022021548_BUILDING.txt.gz
> 
> g++-4.9 -DLINUX -D_GNU_SOURCE -DCC_INTERP -DZERO -DAARCH64
> -DZERO_LIBARCH=\"aarch64\" -DPRODUCT -I.
> -I/«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/prims
> -I/«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm
> -I/«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/precompiled
> -I/«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/cpu/zero/vm
> -I/«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/os_cpu/linux_zero/vm
> -I/«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/os/linux/vm
> -I/«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/os/posix/vm
> -I../generated -DHOTSPOT_RELEASE_VERSION="\"24.85-b03\""
> -DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"buildd\""
> -DHOTSPOT_LIB_ARCH=\"aarch64\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\""
> -DDERIVATIVE_ID="\"IcedTea 2.6.2pre02\""
> -DDEB_MULTIARCH="\"aarch64-linux-gnu\"" -DDISTRIBUTION_ID="\"Ubuntu
> 15.10, package 7u91-2.6.2-0ubuntu1~pre02~20151022021548\""
> -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_zero -DTARGET_ARCH_MODEL_zero
> -DTARGET_OS_ARCH_linux_zero -DTARGET_OS_ARCH_MODEL_linux_zero
> -DTARGET_COMPILER_gcc  -fpic -fno-rtti -fno-exceptions -D_REENTRANT
> -fcheck-new -fvisibility=hidden -D_LITTLE_ENDIAN -pipe -g -O3
> -fno-strict-aliasing -fno-devirtualize -DVM_LITTLE_ENDIAN -D_LP64=1
> -DINCLUDE_TRACE=1  -Wpointer-arith -Wsign-compare   -g
> -fstack-protector-strong -Wformat -Werror=format-security
> -D_FORTIFY_SOURCE=2 -c -fpch-deps -MMD -MP -MF
> ../generated/dependencies/vm_operations.o.d -o vm_operations.o
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/runtime/vm_operations.cpp
> In file included from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/utilities/globalDefinitions.hpp:45:0,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/utilities/debug.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/runtime/globals.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/memory/allocation.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/memory/iterator.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/memory/genOopClosures.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/oops/klass.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/runtime/handles.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/code/oopRecorder.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/asm/assembler.hpp:28,
>                  from
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/precompiled/precompiled.hpp:29:
> /«PKGBUILDDIR»/build/zerovm/openjdk/hotspot/src/share/vm/runtime/vmStructs.cpp:847:20:
> error: '_updateBytesCRC32' is not a member of 'StubRoutines'
>        static_field(StubRoutines,                _updateBytesCRC32,
>                          address)                              \
> 

Ok, I see two issues here.

1. We don't build Zero on AArch64, but the native port instead. It seems that the native
port has broken Zero on AArch64:

  AARCH64_ONLY(                                      \
      static_field(StubRoutines,                _updateBytesCRC32,                             address)                       \
       \
     static_field(StubRoutines,                _crc_table_adr,                                address)                        \
       \
  )                                                  \

I'll add a NOT_ZERO wrapper.

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2683

2. I think the reason you've ended up building Zero (assuming you're not explicitly setting
--enable-zero on AArch64) is that the IT_HAS_NATIVE_HOTSPOT_PORT test uses host_cpu and
it's using arm64, not aarch64. I'll fix this also.

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2684
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07