[rfc][icedtea-web] manager for desktop integration

[Jiri Vanek]

On 10/23/2015 05:46 PM, Jacob Wisor wrote:
> On 10/23/2015 at 04:45 PM Jiri Vanek wrote:
>> Hello.
>>
>> here is long ago promised manager for desktop integration.
>>
>> Considering how compact the change is, I'm playing with idea of 1.6 backport
>> (who knows when 1.7 will go alive....)
>>
>> The ico class is from this article:
>> http://www.informit.com/articles/article.aspx?p=1186882&seqNum=2
>> I contacted the author, and got no response in last two days. I did nto found
>> any license...
>> If he will not reply - drop the ico-format view? Depend on image4j?
>
> Hmm, could you please explain why IcedTea-Web should need an ico file decoder? AFAIK, the JNLP

Reasonable question.

When  generates files for desktop integration, when all other ways fails, it tries also favicon.ico
Generally guessed, there can be quite a couple of those in cons' cache dir.

In this patch, when list of all cached icons is populated, previews are generated. It would be sad 
to miss preview of .ico files (as short-cuts visual icon is for desktop usage most reminding thing)

So generally not needed, but nice to have.

> specification only allows internet image file formats, like png, jpg, gif, and mng, but does not
> accept ico files for applet/application icons.
>
>> I'm for inclusion, and removal in case of complain.
>
> No, let's not haste again, okay? Please, respect the license and thus respect the order of doing

If there would be some license to respect... :( But otherwise ok. He did not write up to now, so I 
guess ico support is going away unless you agree on including Ico.java and possible delete on 
Authors complain) (Ico is moreover wrapper about png anyway. If we disagree here to much, I will 
write my own very probably...)

> things.
>
>> I will move texts form hardcoded to properties in another round or before push.
>
> Good, but it would be nice if you would post this in a further patch for review because there are

Done.

The strings were already here. You could review them already instead simple "plenty of oddly written 
English messages"
> plenty of oddly written English messages and key name spelling mistakes. This way I can check that
> before it gets into the repo. ;-)
>
> Regards,
>

J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: desktopIntegrationMAnager2.patch
Type: text/x-patch
Size: 80972 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20151026/a7b640f4/desktopIntegrationMAnager2-0001.patch>