[rfc][icedtea-web] manager for desktop integration

[Jiri Vanek]

On 10/27/2015 02:56 PM, Jiri Vanek wrote:
> On 10/26/2015 06:45 PM, Jacob Wisor wrote:
>> On 10/26/2015 at 03:39 PM Jiri Vanek wrote:
>>> On 10/23/2015 05:46 PM, Jacob Wisor wrote:
>>>> On 10/23/2015 at 04:45 PM Jiri Vanek wrote:
>> Anyways, a few comments on the patch:
>>
>> Please try to replace most of the code where you concatenate strings with StringBuilder.append() (or
>> StringBuilder.xxx() etc) where applicable, but especially where you build some HTML for preview.
>> Please also remember to chain StringBuilder calls much as possible. This should give best
>> performance results. Although the compiler does some "automagic" StringBuilder conversion when using
>> the + operator on strings, it still lacks the analysis quality of a human brain and thus does not do
>> much chaining. ;-)
>
> Sure .. will be done.
>
...
> [*]
> in light of [**]..... I will go with the patch without ico support.
> And will again[***] try spi provider. As it may be really usefull. And post ico support as separate
> patch. Lets see how it will be sucessful as.. bad luck... I already[***] tried to add wraper about
> this Ico.java providing spi support. After several hours I discarded it as not necessary. But
> because of [**]  lets try again....
>
>
> J.

So here is the patch with fixed string builders[2] and removed ico.java

I'm working on spi wrapper around that ico file. It may take so long that the author will rpely :) 
(imho following http://www.daubnet.com/en/file-format-ico is much more simple then following 
https://docs.oracle.com/javase/7/docs/api/javax/imageio/spi/ImageReaderSpi.html#ImageReaderSpi%28java.lang.String,%20java.lang.String,%20java.lang.String[],%20java.lang.String[],%20java.lang.String[],%20java.lang.String,%20java.lang.Class[],%20java.lang.String[],%20boolean,%20java.lang.String,%20java.lang.String,%20java.lang.String[],%20java.lang.String[],%20boolean,%20java.lang.String,%20java.lang.String,%20java.lang.String[],%20java.lang.String[]%29
or even https://docs.oracle.com/javase/7/docs/api/javax/imageio/spi/package-summary.html)

If I will suceed with this spi wrapper, then maybe contributing those spis to image4j[1] and using 
it may be better approach. But still I'm hestitaing about third party library for such simple 
thing... (and  bmp is useless anyway...)


J.


[1]
http://image4j.sourceforge.net/
[2] What have I done! It belonged to http://www.hovnokod.cz/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: desktopIntegrationMAnager3-noIco_stringBUilders.patch
Type: text/x-patch
Size: 64973 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20151027/494a633c/desktopIntegrationMAnager3-noIco_stringBUilders-0001.patch>