[rfc][icedtea-web] manager for desktop integration

[Jiri Vanek]

>
>
> [*]
> in light of [**]..... I will go with the patch without ico support.
> And will again[***] try spi provider. As it may be really usefull. And post ico support as separate
> patch. Lets see how it will be sucessful as.. bad luck... I already[***] tried to add wraper about
> this Ico.java providing spi support. After several hours I discarded it as not necessary. But
> because of [**]  lets try again....
>

So I created spi for Ico (still based on the same file - one update - the example is no loner 
available on that page :D ( I guess they removed it when I asked them for usage)

Further.... Yes, ImageIO.read and *relatives* can read ico files. BUT eg suntoolkit.createImage can 
NOT. Thats a bit of betrayal because it and its  *relatives* are used for reading and especially 
asynchronous reading of images pretty often. It can be traced in ITW itself on some places.
Yes we can fix it in ITW, But eg jtextpane used in this original patch or other users of 
toolkit.createImage can not.

if you will be wondering why it can not read it, you will end at:


   protected ImageDecoder getDecoder(InputStream is) {
         if (!is.markSupported())
             is = new BufferedInputStream(is);
         try {
           /* changed to support png
              is.mark(6);
              */
           is.mark(8);
             int c1 = is.read();
             int c2 = is.read();
             int c3 = is.read();
             int c4 = is.read();
             int c5 = is.read();
             int c6 = is.read();
             // added to support png
             int c7 = is.read();
             int c8 = is.read();
             // end of adding
             is.reset();
             is.mark(-1);

             if (c1 == 'G' && c2 == 'I' && c3 == 'F' && c4 == '8') {
                 return new GifImageDecoder(this, is);
             } else if (c1 == '\377' && c2 == '\330' && c3 == '\377') {
                 return new JPEGImageDecoder(this, is);
             } else if (c1 == '#' && c2 == 'd' && c3 == 'e' && c4 == 'f') {
                 return new XbmImageDecoder(this, is);
//          } else if (c1 == '!' && c2 == ' ' && c3 == 'X' && c4 == 'P' &&
//                     c5 == 'M' && c6 == '2') {
//              return new Xpm2ImageDecoder(this, is);
                 // added to support png
             } else if (c1 == 137 && c2 == 80 && c3 == 78 &&
                 c4 == 71 && c5 == 13 && c6 == 10 &&
                 c7 == 26 && c8 == 10) {
                 return new PNGImageDecoder(this, is);
             }
             // end of adding
         } catch (IOException e) {
         }

         return null;
     }




Yes. reimplemented wheel in JDK itself :-///



So what now?

  J.