bug in deploymentpropertiesmodifier

[Andrew Azores]

On 01/09/15 08:39 AM, Jiri Vanek wrote:
> Hello!
>
> If you get back to loop, may you fx one error?
>
>
> deployment properties may contains commented-out values
>
> #Netx deployment configuration
> #Mon Aug 31 13:20:09 CEST 2015
> #deployment.manifest.attributes.check=ALL
> deployment.security.level=ALLOW_UNSIGNED
> deployment.manifest.attributes.check=NONE
>
> When deployment properties modifier is applied,
> then it seem to me that it uncomment value, as I have seen during 
> processing above file changed to:
>
> #Netx deployment configuration
> #Mon Aug 31 13:20:09 CEST 2015
> deployment.manifest.attributes.check=ALL
>
> deployment.security.level=ALLOW_UNSIGNED
> deployment.manifest.attributes.check=NONE
>
> Thats definitely incorrect. MAy you verify and fix?
>
> Thanx!
>
>
> J.
>
>
>

I'm not sure how to get the tests-extensions-tests for this to run to 
verify that the changes are correct, but it looks like it probably works 
properly from manual testing. All comments in the file get remembered 
and removed, and then reinserted at the end of the file on restore. They 
go at the end just to be sure that the property restore process doesn't 
accidentally restore values into a commented line - it isn't the most 
elegant solution, but it should work.

-- 
Thanks,

Andrew Azores

-------------- next part --------------
A non-text attachment was scrubbed...
Name: deployment-properties-modifier.patch
Type: text/x-patch
Size: 6060 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20150901/d3ee77dc/deployment-properties-modifier.patch>