[Bug 2786] New: IllegalStateException zip file closed when accessing Jar file over HTTP

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=2786

            Bug ID: 2786
           Summary: IllegalStateException zip file closed when accessing
                    Jar file over HTTP
           Product: IcedTea-Web
           Version: 1.5
          Hardware: x86_64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: NetX (javaws)
          Assignee: jvanek at redhat.com
          Reporter: trineo at gmail.com
                CC: unassigned at icedtea.classpath.org

This works fine with Oracle's javaws from JDK 6, JDK 7, and JDK 8
$ javaws http://nextmidas.techma.com/nxm353/htdocs/shell.jnlp


running with icedtea-web 1.5.1 (rhel-1.el6-x86_64)

$ javaws.itweb http://nextmidas.techma.com/nxm353/htdocs/shell.jnlp
..
[ITW-JAVAWS][MESSAGE_DEBUG][Thu Jan 14 15:57:21 EST
2016][net.sourceforge.jnlp.runtime.JNLPProxySelector.select(JNLPProxySelector.java:211)]
NETX Thread# 1c5baf07, name NeXtMidas SHELLGUI 3.5.3 Selected proxies: [DIRECT]
java.lang.IllegalStateException: zip file closed
    at java.util.zip.ZipFile.ensureOpen(ZipFile.java:634)
    at java.util.zip.ZipFile.getEntry(ZipFile.java:305)
    at java.util.jar.JarFile.getEntry(JarFile.java:227)
    at
sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:132)
    at
sun.net.www.protocol.jar.JarURLConnection.getJarFile(JarURLConnection.java:89)
    at nxm.sys.lib.JarResource.getFile(JarResource.java:102)
    at nxm.sys.lib.JarResource.exists(JarResource.java:110)
    at nxm.sys.lib.BaseFile.find(BaseFile.java:279)
    at nxm.sys.lib.Shell.configure(Shell.java:782)
    at nxm.sys.lib.Shell.open(Shell.java:318)
    at nxm.sys.lib.Shell.run(Shell.java:244)
    at nxm.sys.lib.Shell.run(Shell.java:218)
    at nxm.sys.lib.Shell.runNew(Shell.java:207)
    at nxm.sys.lib.Webstart.main(Webstart.java:25)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at net.sourceforge.jnlp.Launcher.launchApplication(Launcher.java:565)
    at net.sourceforge.jnlp.Launcher$TgThread.run(Launcher.java:905)

---
running with icedtea-web 1.6.1 (rhel-4.el7-x86_64)

$ javaws.itweb http://nextmidas.techma.com/nxm353/htdocs/shell.jnlp
java.lang.IllegalStateException: zip file closed
    at java.util.zip.ZipFile.ensureOpen(ZipFile.java:669)
    at java.util.zip.ZipFile.getEntry(ZipFile.java:309)
    at java.util.jar.JarFile.getEntry(JarFile.java:240)
    at
sun.net.www.protocol.jar.JarURLConnection.connect(JarURLConnection.java:132)
    at
sun.net.www.protocol.jar.JarURLConnection.getJarFile(JarURLConnection.java:89)
    at nxm.sys.lib.JarResource.getFile(JarResource.java:102)
    at nxm.sys.lib.JarResource.exists(JarResource.java:110)
    at nxm.sys.lib.BaseFile.find(BaseFile.java:279)
    at nxm.sys.lib.Shell.configure(Shell.java:782)
    at nxm.sys.lib.Shell.open(Shell.java:318)
    at nxm.sys.lib.Shell.run(Shell.java:244)
    at nxm.sys.lib.Shell.run(Shell.java:218)
    at nxm.sys.lib.Shell.runNew(Shell.java:207)
    at nxm.sys.lib.Webstart.main(Webstart.java:25)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at net.sourceforge.jnlp.Launcher.launchApplication(Launcher.java:574)
    at net.sourceforge.jnlp.Launcher$TgThread.run(Launcher.java:936)


==
our code is doing something like the below (shown without type checks) to show
the flow:

 public boolean exists(String urlstr) {
   URL url = new URL(urlstr);  // #1
   JarURLConnection conn = (JarURLConnection) url.openConnection(); // #2
   JarFile jarFile = conn.getJarFile(); // #3
   // do some checks and set boolean results // #4
   jarFile.close(); // #5
   return result; // #6
 }

we call exists("jar:...."); multiple times pointing to the same URL which seems
to be the cause of this issue.
If we comment out line #5, we don't see the issue but this leave potential for
a resource leak (at least with Oracle's Java)

Again, with the above, it works fine with Oracle's javaws from JRE/JDK 6, 7,
and 8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20160114/5f07ad48/attachment.html>