[rfc][icedtea-web] PR2489 - various NPEs when codebase is null

Jiri Vanek jvanek at redhat.com
Fri Jan 15 14:44:57 UTC 2016

Hello, this is - not sure how complex - fix for PR2489.
The test is not finished, and I will not push before it is finished.

Generally. our jnlpFile.codebase is based on value from jnlpFile/htmlAppletTag or deducete if it is "." or something like this.
However, when codebase attribute is missing, it is null.

I'm not sure how important parts of ITW are dealing with this, but all parts around extendedAppletsSecurity were designed with null==ignore. That appeared incorrect later, and now there is several NPE posibilities.

I think it is not good idea to force getCodebase to not return null.

The correct repalcement is getSourceLocation - see fix to "align jnlp_href to oracle jdk" for expalantion.

But I'm not sure how widely to use I'm really scared to include it inside getCodebase.

See you later with full version of test, bu I would be greategull for thoughts.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PR2489fix+tests.patch
Type: text/x-patch
Size: 62737 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20160115/38834eef/PR2489fixtests-0001.patch>

More information about the distro-pkg-dev mailing list