[Bug 3151] [IcedTea7] Zero build fails with pch disabled

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3151

--- Comment #15 from Tiago Stürmer Daitx <tdaitx at gmail.com> ---
I also had an ZeroEntry "not declared" when building it with PCH disabled on
amd64, but instead of nativeInst_zero.o my issue triggered when building
methodHandles_zero.o:

g++-5 -DLINUX -D_GNU_SOURCE -DCC_INTERP -DZERO -DAMD64 -DZERO_LIBARCH=\"amd64\"
-DPRODUCT  -I<snip>/hotspot/src/share/vm/prims -I<snip>/hotspot/src/share/vm
-I<snip>/hotspot/src/share/vm/precompiled -I<snip>/hotspot/src/cpu/zero/vm
-I<snip>/hotspot/src/os_cpu/linux_zero/vm -I<snip>/hotspot/src/os/linux/vm
-I<snip>/hotspot/src/os/posix/vm -I../generated
-DHOTSPOT_RELEASE_VERSION="\"24.111-b01\"" -DHOTSPOT_BUILD_TARGET="\"product\""
-DHOTSPOT_BUILD_USER="\"tdaitx\"" -DHOTSPOT_LIB_ARCH=\"amd64\"
-DHOTSPOT_VM_DISTRO="\"OpenJDK\"" -DDERIVATIVE_ID="\"IcedTea 2.6.7\""
-DDEB_MULTIARCH="\"x86_64-linux-gnu\"" -DDISTRIBUTION_ID="\"Ubuntu 16.10,
package 7u111-2.6.7-0ubuntu0.16.10~01\"" -DTARGET_OS_FAMILY_linux
-DTARGET_ARCH_zero -DTARGET_ARCH_MODEL_zero -DTARGET_OS_ARCH_linux_zero
-DTARGET_OS_ARCH_MODEL_linux_zero -DTARGET_COMPILER_gcc  -std=gnu++98 -fpic
-fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=hidden -m64
-pipe -DDONT_USE_PRECOMPILED_HEADER -g -O2 -finline-functions
-fno-strict-aliasing -DVM_LITTLE_ENDIAN -D_LP64=1 -DINCLUDE_TRACE=1 
-Wpointer-arith -Wsign-compare   -g
-fdebug-prefix-map=/home/tdaitx/openjdk-7-7u111-2.6.7=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -c -fpch-deps -MMD -MP -MF
../generated/dependencies/methodHandles_zero.o.d -o methodHandles_zero.o
<snip>/hotspot/src/cpu/zero/vm/methodHandles_zero.cpp

[various warnings]

In file included from
<snip>/hotspot/src/share/vm/interpreter/cppInterpreterGenerator.hpp:57:0,
                 from
<snip>/hotspot/src/share/vm/interpreter/interpreterGenerator.hpp:29,
                 from <snip>/hotspot/src/cpu/zero/vm/methodHandles_zero.cpp:28:
<snip>/hotspot/src/cpu/zero/vm/cppInterpreterGenerator_zero.hpp: In static
member function 'static u_char*
CppInterpreterGenerator::generate_entry_impl(MacroAssembler*, address)':
<snip>/hotspot/src/cpu/zero/vm/cppInterpreterGenerator_zero.hpp:36:5: error:
'ZeroEntry' was not declared in this scope
     ZeroEntry *entry = (ZeroEntry *) masm->pc();
     ^
<snip>/hotspot/src/cpu/zero/vm/cppInterpreterGenerator_zero.hpp:36:16: error:
'entry' was not declared in this scope
     ZeroEntry *entry = (ZeroEntry *) masm->pc();
                ^
<snip>/hotspot/src/cpu/zero/vm/cppInterpreterGenerator_zero.hpp:36:36: error:
expected primary-expression before ')' token
     ZeroEntry *entry = (ZeroEntry *) masm->pc();



I tried a few things and I notice that I could get methodHandles build when
share/vm/precompiled/precompiled.hpp contained just a single line:

# include "ci/ciConstant.hpp"

Note: since it contains just that, -DDONT_USE_PRECOMPILED_HEADER gets ignored
as there is no #ifndef.

By comparing the the header dependencies generated by the arguments
"-MMD -MF ../generated/dependencies/methodHandles_zero.o.d"
between the above working build and the non pch failing build I noticed that
the actual inclusion of "share/vm/interpreter/interpreterGenerator.hpp" was
moved way after "entry_zero.hpp".

After realizing that I added a "#include entry_zero.hpp" in
cpu/zero/vm/methodHandles_zero.cpp in line 28 (ie. before
interpreterGenerator.hpp) and that fixed the problem.


So afterall the problem seems to be that some hpp/cpp file is missing the
entry_zero.hpp include. I'm not sure methodHandles_zero.cpp is indeed the right
file for that, but it worked. ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20161024/f68bcbf7/attachment-0001.html>