[rfc] added preprocessing to rust launchers

[Jiri Vanek]

On 12/08/2017 11:21 AM, Jiri Vanek wrote:
> On 12/06/2017 07:46 PM, Alex Kashchenko wrote:
>> On 12/06/2017 02:50 PM, Jiri Vanek wrote:
>>> Hello!
>>>
>>> Thanx for feedback. I had week long personal battle whether to have it preprocessed with some 
>>> solid defaults, or to use config file. It ehnded 51:49 for preprocess. No it is 99:1 for config 
>>> file:)
>>>
>>> What location do you suggest?
>>
>> The same directory, where launcher binary is, will be the most convenient. So it can be read with: 
>> executable_directory() + "/conf_file_name".
> 
> But that is no way with linux fs conventions for distribution packages.
> 
> So the fall back will need to stay in place
> 
> 1)xdg_confidir/icedtea-web/conf_file_name
> 2)executable_directory() + :/conf_file_name".

hmm. that is user specific:(

So /etc/java/icedtea-web will need to be there to...
> Anything more?
> 
> where conf_file_name I would vote for .itw_default_paths
> 
> And the file should be read only :)
> 
> Thanx for thoughts!
>    J.
>>
>>>
>>>
>>> On 12/06/2017 01:12 PM, Alex Kashchenko wrote:
>>>> Hi,
>>>>
>>>> On 12/05/2017 04:11 PM, Jiri Vanek wrote:
>>>>> This patch is adding the possiblity to pas classapth and simialr to the rust luncher.
>>>>> If there is enybody knowing the better way, and especially how to get rid of this duplicated 
>>>>> (triplicated x triplicated) snipept of
>>>>> +    MAIN_CLASS=net.sourceforge.jnlp.runtime.Boot ;\
>>>>> +    BIN_LOCATION=$(bindir)/$(javaws).sh ;\
>>>>> +    PROGRAM_NAME=$(javaws) ;\
>>>>> +    $(edit_launcher_script) < $< > $@
>>>>>
>>>>> And turn it into function of call(name, suffix)  < $< > $@, that would be awesome. I tried many 
>>>>> times, various ways, but if I get rid of those three lines, I always duplicated  targets:(
>>>>
>>>> I can suggest not to pre-process .rs file, but to preprocess config file instead and read it on 
>>>> startup.
>>>>
>>>>
>>>
>>>
>>
>>
> 
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109