[PATCH] MSI installer for IcedTea-Web
Jiri Vanek
jvanek at redhat.com
Tue May 9 09:23:54 UTC 2017
On 05/05/2017 05:29 PM, Alex Kashchenko wrote:
> Hi,
>
> This patch [1] adds a basic (draft) support for building MSI windows installer for ITW. It adds
> "installer-win" target that wraps results of "install" target into MSI. Build commands that worked
> for me:
As this discussion started offlist, short summary why to depend on make-install.
On cygwin, make isntall do a bit more then on pure linux (bat launchers, dependencies), and on top
of all, the resulting window "binaries" are relocatable.
And they are bianaries, so any distribution of binary blob (new to ITW) needs to be done from
binary image.
>
> bash autogen.sh
> bash configure --with-jdk-home=C:/path/to/jdk --disable-native-plugin
> --with-tagsoup=c:/path/to/tagsoup-1.2.1.jar
I wish to change tagsoup to mandatory, but IIRC gentoo was not happy from it.
> rd /s /q c:\cygwin64\usr\local
> make installer-win
Thanx! I read it all and looks awesome. Several ideas pledged on end
>
> Known limitations:
>
> 1) cygwin must be installed into c:/cygwin64 directory and must have the following packages - make,
> automake, autoconf, pkg-config, zip
see below
>
> 2) jdk, WiX [2][3] and wixgen [4][5] must be in PATH
again, please below
>
> 3) all values in installer.json descriptor are hardcoded
This looks ook to me, jsut may need to be sed during preparation.
>
> 4) registry values for jnlp:// protocol registration [6] are set incorrectly because wixgen
> currently cannot create "(Default)" registry values (I'll fix that)
Cool!
>
> 5) installer uses default images taken from here [7], icon is taken from here [8]; they probably
> need to be replaced
Yup. I think it is ok to push them now, and replace the actual content later. I will ping the guy
who did original logo. MAybe he will wont to play with it. If not, I will do something on my own (or
feel free to do so). Only thing I thnink it shouldbe laigned to, is current itw logo:
http://icedtea.classpath.org/wiki/Image:Javaws_splash.png
>
> Resulting installer example [9]
Looks good :))
Will take some time to improve my win VM to actually verify building it.
>
>
> [1] http://cr.openjdk.java.net/~akasko/itw/msi_20170505.patch
> [2] http://wixtoolset.org/
> [3] https://github.com/ojdkbuild/tools_wix
> [4] https://github.com/akashche/wixgen
> [5] https://github.com/ojdkbuild/tools_wixgen
> [6]
> https://bugs.openjdk.java.net/browse/JDK-8055464?focusedCommentId=13647232&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13647232
>
> [7] https://github.com/wixtoolset/wix3/tree/develop/src/ext/UIExtension/wixlib/Bitmaps
> [8] http://icedtea.classpath.org/favicon.ico
> [9] https://bitbucket.org/akashche/downloads/downloads/itw_20170505.msi
>
diff --git a/Makefile.am b/Makefile.am
--- a/Makefile.am
+++ b/Makefile.am
@@ -301,10 +301,15 @@
rmdir stamps ; \
fi
+installer-win: install
+ cmd /c wixgen c:/cygwin64/usr/local -c installer/installer.json -o installer.wxs
+ candle /nologo installer.wxs
+ light /nologo -ext WixUIExtension installer.wixobj
+
All those must be checked in configure. Can be another patch. (cygwin, wixgen, candle, light (cmd??))
.PHONY: clean-IcedTeaPlugin clean-add-netx clean-add-netx-debug clean-add-plugin
clean-add-plugin-debug \
clean-bootstrap-directory clean-native-ecj clean-desktop-files clean-netx-docs clean-docs
clean-plugin-docs clean-generated-docs clean-icedteaweb-completion\
clean-tests check-local clean-launchers stamps/check-pac-functions.stamp
stamps/run-netx-unit-tests.stamp clean-netx-tests \
- clean-junit-runner clean-netx-unit-tests clean-metadata
+ clean-junit-runner clean-netx-unit-tests clean-metadata installer-win
install-exec-local:
${mkinstalldirs} $(DESTDIR)$(bindir) $(DESTDIR)$(datadir)/$(PACKAGE_NAME)/ $(DESTDIR)$(libdir)
$(ICONS_DEST_DIR) $(BASH_CMPL_DEST_DIR)
diff --git a/installer/LICENSE.rtf b/installer/LICENSE.rtf
new file mode 100644
--- /dev/null
+++ b/installer/LICENSE.rtf
...
Can this be done better?
ITW have mechanism how to generate docs from properties. Hoewer, this document really looks like it
should go by its own way.
Also the mechanism in ITW do not support RTF.
Does that MSI generator support HTML?
On contrary, we already have GPL2 in sources (and this generated). Maybe it can be reused?
How about localisations? Itw supports de+pl+cz mutations. Can it be reflected in installer? If so,
it should be more tightened with ITW docs generation.
...
diff --git a/installer/greetings_banner.bmp b/installer/greetings_banner.bmp
...
diff --git a/installer/icon.ico b/installer/icon.ico
...
diff --git a/installer/top_banner.bmp b/installer/top_banner.bmp
...
Seriously, Bmps? But I guess the generation proces and resulting technology do not left you much
choices...
diff --git a/installer/installer.json b/installer/installer.json
This looks this is an heart beat. I somehow miss where are listed files it is supposed to pack....
Or was it "wixgen c:/cygwin64/usr/local" Can this command be a bit more specific? I dont think we
wont cygwin launchers here.
Can policy-tool and itw-settings (as ControlPAnel) have menu shoertcut?
Can html documentation be somehow handled? Idally menu shortcut to index.html?
new file mode 100644
--- /dev/null
+++ b/installer/installer.json
@@ -0,0 +1,60 @@
+{
+ "appName": "IcedTea-Web 1.7",
+ "versionMajor": "1",
+ "versionMinor": "7",
+ "versionMicro": "0",
+ "versionPatch": "0",
+ "vendor": "IcedTea-Web open-source project",
+ "installDirName": "WebStart",
+ "helpLink": "http://icedtea.classpath.org/wiki/IcedTea-Web",
+ "productUuid": "03ae99a2-d9b6-46af-9841-c4b810289b1b",
+ "updateUuid": "ff98de21-a283-40be-b0a5-74a6a4219de8",
+ "vendorDirName": "IcedTeaWeb",
+ "licenseFilePath": "installer/LICENSE.rtf",
+ "iconPath": "installer/icon.ico",
+ "topBannerBmpPath": "installer/top_banner.bmp",
+ "greetingsBannerBmpPath": "installer/greetings_banner.bmp",
+ "useFeatureTree": false,
+ "featureId": "itw",
+ "featureTitle": "IcedTea-Web",
+ "featureDescription": "Free Software implementation of Java Web Start, originally based on the
NetX project",
+
+ "registryKeys": [
+ {
+ "root": "HKCR",
+ "key": "jnlp",
+ "values": [
+ {
+ "type": "string",
+ "name": "TODO_DEFAULT",
+ "value": "URL:jnlp Protocol"
+ },
+ {
+ "type": "string",
+ "name": "URL Protocol",
+ "value": ""
+ }
+ ]
+ },
+ {
+ "root": "HKCR",
+ "key": "jnlp\\shell\\open\\command",
+ "values": [
+ {
+ "type": "string",
+ "name": "TODO_DEFAULT",
+ "value": "\"[INSTALLDIR]bin\\javaws.bat\" \"%1\""
+ }
+ ]
+ }
+ ],
+ "environmentVariables": [
+ {
+ "name": "PATH",
+ "action": "set",
+ "part": "last",
+ "value": "[INSTALLDIR]bin"
+ }
+ ]
+}
+
Thanx again!
J.
--
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com M: +420775390109
More information about the distro-pkg-dev
mailing list