[PATCH] MSI installer for IcedTea-Web

[Jiri Vanek]

On 05/09/2017 02:25 PM, Alex Kashchenko wrote:
> Hi,
> 
> Attaching updated patch, the only change is that name of in-tree installer dir and name of make 
> target are changed to "win-installer" - http://cr.openjdk.java.net/~akasko/itw/msi_20170509.patch

Thanx!
> 
> Some comments below:
> 
> On 05/09/2017 10:23 AM, Jiri Vanek wrote:
>>
>> [...]
>>
>>> 3) all values in installer.json descriptor are hardcoded
>>
>> This looks ook to me, jsut may need to be sed during preparation.
> 
> Yes, filtering should be added for version number, dist path and maybe for some labels.


Good. Thanx for writing this down.
> 
>>
>> Yup. I think it is ok to push them now, and replace the actual content
>> later. I will ping the guy who did original logo. MAybe he will wont to
>> play with it. If not, I will do something on my own (or feel free to do
>> so). Only thing I thnink it shouldbe laigned to, is current itw logo:
>> http://icedtea.classpath.org/wiki/Image:Javaws_splash.png
> 
> A note about icon, it should be multi-sized, see http://stackoverflow.com/a/16922387/314015
Sure. Thanx for highlighting it,

> 
>> [...]
>> +installer-win: install
>> +    cmd /c wixgen c:/cygwin64/usr/local -c installer/installer.json -o
>> installer.wxs
>> +    candle /nologo installer.wxs
>> +    light /nologo -ext WixUIExtension installer.wixobj
>> +
>>
>>
>>
>> All those must be checked in configure. Can be another patch. (cygwin,
>> wixgen, candle, light (cmd??))
> 
> M, ideally these should be controlled from configure, but windows builds requires specially-prepared 
> environment (including specially prepared PATH) anyway.

Configure can check it all. Including path. This will need to be (yours) another changeset
> 
>>
>> [...]
>> +++ b/installer/LICENSE.rtf
>> ...
>>
>> Can this be done better?
>> ITW have mechanism how to generate docs from properties.  Hoewer, this
>> document really looks like it should go by its own way.
>> Also the mechanism in ITW do not support RTF.
>> Does that MSI generator support HTML?
>> On contrary,  we already have GPL2 in sources (and this generated).
>> Maybe it can be reused?
> 
> AFAIK, only RTF is supported ( 
> http://wixtoolset.org/documentation/manual/v3/wixui/wixui_customizations.html#specifying-a-license-file 
> ), included file is copy of ITW license from root dir.

oook:(

> 
>>
>> How about localisations? Itw supports de+pl+cz mutations. Can it be
>> reflected in installer? If so, it should be more tightened with ITW docs
>> generation.
> 
> In theory installer forms can be localized, but I have no experience with that.

Fair enough. lets skip it for now.
> 
>> [...]
>> ...
>> diff --git a/installer/top_banner.bmp b/installer/top_banner.bmp
>> ...
>>
>> Seriously, Bmps?  But I guess the generation proces and resulting
>> technology do not left you much choices...
> 
> Yes, bitmaps are required. Can be reconverted from png/svg using java tools (batik) during build 
> time if that will be convenient.

Nope:) lets keep it :)
> 
>> [...]
>> diff --git a/installer/installer.json b/installer/installer.json
>>
>>
>> This looks this is an heart beat. I somehow miss where are listed files
>> it is supposed to pack....
>> Or was it "wixgen c:/cygwin64/usr/local" Can this command be a bit more
>> specific? I dont think we wont cygwin launchers here.
> 
> We have two options:
> 
> 1) include installer XML descriptor (example: http://cr.openjdk.java.net/~akasko/itw/installer.wxs ) 
> in-tree and maintain it

aaarrrgggg
> 
> 2) prepare a "win_dist" directory for installer and generate XML descriptor over it (specifying 
> metadata in JSON).
> 
> Currently the second variant is used and "make install" results are treated as "win_dist".

Yup. looks better. I will be adding some target win-dist (depnding on install) which will do the 
filtering job. So the win-installer target can depend and use this filtered result.
> 
>>
>> Can policy-tool and itw-settings (as ControlPAnel) have menu shoertcut?
> 
> Yes, menu-entries/shortcuts can be added, but they (1) required icons, (2) need to be added to wixgen

Please keep this in mind. I think it is necessary to add win7-like menu items and/or win8+ search tags.

> 
>> Can html documentation be somehow handled? Idally menu shortcut to
>> index.html?
> 
> I think the following options are possible:
> 
> 1) generate CHM file from HTMLs

nope :)
> 
> 2) include link to ITW web-site instead

Various itw htnl pages can be linked from various installer steps (even license). Docs can be also 
one of them (http://icedtea.wildebeest.org/download/icedtea-web-docs/) .
> 
> 3) include HTMLs and a shortcut to index.html

I really it is worthy to do so. And again, include in menu/search
> 

Again, thanx a lot!


I will include this changeset, just please give me some time (feel free to improve this one in 
meantime)  - I need to finish some some other errands and tune my win VM:(

J.





-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109