[PATCH] MSI installer for IcedTea-Web

[Jiri Vanek]

Hi Alex!

Few minutes ago, I pushed very unfair push considering you and yours MSI patch (the pure windows 
image and windows binary archive)

Do you think you can adapt your patch? The main difference will be to depend on win-only-image 
instead of install.

Also, please rename installer.json to isntaller.json.in and iclude basic sedding (jsut necessary 
parts.if nothing is necessary, then jsut copy it, But th elogic itself is necessary)

Also, can  you please include Michal's patch and add yourself and Michal to authors?

If you will lack and will or time to do so, I will adapt your patch yesterday (unless you have 
anything against)

Keep in mind, we have to add configure checks for wixentools...

Thanx a lot!
   J.


On 05/10/2017 10:41 AM, Michal Vala wrote:
> Hi,
> 
> this patch https://michalvala.fedorapeople.org/icedtea-windows-build/win_jars.patch adds default 
> paths for all jars needed for build in configure. Jars has to be placed in same places as for linux 
> build from cygwin point of view.
> Patch can be simplified by processing jar path with cygpath in IT_FIND_OPTIONAL_JAR.
> 
> 
> On 05/05/2017 05:29 PM, Alex Kashchenko wrote:
>> Hi,
>>
>> This patch [1] adds a basic (draft) support for building MSI windows installer for ITW. It adds 
>> "installer-win" target that wraps results of "install" target into MSI. Build commands that worked 
>> for me:
>>
>> bash autogen.sh
>> bash configure --with-jdk-home=C:/path/to/jdk --disable-native-plugin 
>> --with-tagsoup=c:/path/to/tagsoup-1.2.1.jar
>> rd /s /q c:\cygwin64\usr\local
>> make installer-win
>>
>> Known limitations:
>>
>> 1) cygwin must be installed into c:/cygwin64 directory and must have the following packages - 
>> make, automake, autoconf, pkg-config, zip
>>
>> 2) jdk, WiX [2][3] and wixgen [4][5] must be in PATH
>>
>> 3) all values in installer.json descriptor are hardcoded
>>
>> 4) registry values for jnlp:// protocol registration [6] are set incorrectly because wixgen 
>> currently cannot create "(Default)" registry values (I'll fix that)
>>
>> 5) installer uses default images taken from here [7], icon is taken from here [8]; they probably 
>> need to be replaced
>>
>> Resulting installer example [9]
>>
>>
>> [1] http://cr.openjdk.java.net/~akasko/itw/msi_20170505.patch
>> [2] http://wixtoolset.org/
>> [3] https://github.com/ojdkbuild/tools_wix
>> [4] https://github.com/akashche/wixgen
>> [5] https://github.com/ojdkbuild/tools_wixgen
>> [6] 
>> https://bugs.openjdk.java.net/browse/JDK-8055464?focusedCommentId=13647232&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13647232 
>>
>> [7] https://github.com/wixtoolset/wix3/tree/develop/src/ext/UIExtension/wixlib/Bitmaps
>> [8] http://icedtea.classpath.org/favicon.ico
>> [9] https://bitbucket.org/akashche/downloads/downloads/itw_20170505.msi
>>
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109