[PATCH] MSI installer for IcedTea-Web

Alex Kashchenko akashche at redhat.com
Thu May 11 13:12:02 UTC 2017


Hi,

Updated version of the patch - 
http://cr.openjdk.java.net/~akasko/itw/msi_20170511.patch

On 05/11/2017 10:27 AM, Jiri Vanek wrote:
>
> [...]
>
>
> Can you please get rid of the wixgen bat file and call directly
> our_configure_set_java wixen.jar args...  ?
>
> The wixen jar msut be checked by configure anyway....

Added configure check for wixgen.jar.

>
> [...]
>
>>
>> Do you think you can adapt your patch? The main difference will be to
>> depend on win-only-image instead of install.

Yes, win-installer now depends on win-only-image.

>>
>> Also, please rename installer.json to isntaller.json.in and iclude
>> basic sedding (jsut necessary parts.if nothing is necessary, then jsut
>> copy it, But th elogic itself is necessary)

Added sedding, but most of the parameters need to be added to configure, 
currently only version string is replaced.

>> Also, can  you please include Michal's patch and add yourself and
>> Michal to authors?

Following Michal's suggestion, added path converting logic for jars.

>
>[...]
>
>> Keep in mind, we have to add configure checks for wixentools...

Added configure check for WiX, its bin dir needs to be added to PATH to 
be found automatically.

Also enhanced configure logic for JDK dir, unfortunately it still must 
be installed on dir path without spaced - too many jdk-related checks 
require that.

>
>  [...]
>


-- 
-Alex


More information about the distro-pkg-dev mailing list