[PATCH] MSI installer for IcedTea-Web

[Jiri Vanek]

On 05/15/2017 10:52 AM, Alex Kashchenko wrote:
> Hi,
> 
> On 05/12/2017 07:36 PM, Alex Kashchenko wrote:
>> Hi,
>>
>> On 05/11/2017 02:12 PM, Alex Kashchenko wrote:
>>> Updated version of the patch -
>>> http://cr.openjdk.java.net/~akasko/itw/msi_20170511.patch
>>
>> Version that was pushed worked fine for me after adding "bin" dir to WiX
>> paths. I think "bin" should be there, as installing wix 3.11.0.1701 with
>> default options I am getting the same directory structure as here -
>> https://github.com/ojdkbuild/tools_wix
>>
>> Patch (also added clean-win-installer target there):
>> http://cr.openjdk.java.net/~akasko/itw/msi_clean_20170512.patch
> 
> Some more changes:
> 
> Correctly register "jnlp://" protocol [1], requires wixgen 1.3 [2].

Thanx! Will be used and tested.

> 
> Read java home from registry (in batch for testing only, need to be re-done eventually) [3].

Hi. This needs major rework. The registy value is just one of the choices.  Lets make it the 
preferred one, but keep others.

I will include the pause command at bottom. As you suggested via IRC.
> 
> Installer logo and icon [4] (greetings_banner, top_banner and icon.ico can be replaced in 
> win-installer dir).
Okkk. Please do an patch, I'm getting  abt lost in this multipatch thread. TY!!

J.


> 
> Resulting installer (with ojdkbuild 8u131 and firefox 64-bit) can successfully run "jnlp://" URL on 
> this page [5] ("Non square pixels" link).

good!!!
> 
> 
> [1] http://cr.openjdk.java.net/~akasko/itw/default_registry_keys_20170515.patch
> [2] https://github.com/akashche/wixgen/releases/tag/1.3
> [3] http://cr.openjdk.java.net/~akasko/itw/bat_launcher_20170515.patch
> [4] https://github.com/akashche/itw_vector_logo
> [5] https://dcm4che.atlassian.net/wiki/display/WEA/DICOM+Samples#DICOMSamples-Nonsquarepixels
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109