[rfc][icedtea-web] improved home finding to use variables first

[Alex Kashchenko]

On 12/07/2018 09:10 AM, Jiri Vanek wrote:
>>>>> 
>>>>> [...]
>>>>> 
>>>>
>>>> I think it is better to avoid using deprecated API in a new code, especially with Rust fast pacing
>>>> release cycle.
>>>
>>> Thsi is very very bad idea... We replaced one waring by six warnings...
>>
>> Why not fix the warnings which can be fixed and suppress others?
> 
> The fix is the same as for env:home_dir - to use implementation from crates.io

I am talking about the warnings in a launcher code, currently (without 
the patch) there are 11 warnings. They are all harmless ("dead_code" 
type), but they produce a lot of garbage output that makes it easy to 
miss possibly important new ones. It should be trivial to suppress 
harmless warnings with #[allow(dead_code)], 
#[allow(non_camel_case_types)] and similar annotations.


>>> Udated patch attached... But I heavily vote for initial env::home_dir
>>
>> linux_pwd module uses linux-specific calls and is not compilable on windows. Please guard it with
>> #[cfg(unix)] where appropriate. Even if we use env::home_dir (that I think is a bad idea) in this
>> patch, we are going to have some platform-specific code anyway that needs to be conditionally excluded.
> 
> I'm still not sure how will be handled OsAccess = new Linux() x new Windows()
> Theoretically this should be the onl palce where any  #[cfg(unix)] shouldbe used.
> Eh both
> GetUserProfileDirectoryW [1] or SHGetKnownFolderPath [2].
>    and
> getuid(),  getpwuid(uid: uid_t)
> 
> Are compilable on both platforms, but failing in runtime if architecture goes wrong.

They are not compilable, even removing usage of "std::os::unix" package 
(that doesn't exist on windows), build will fail on linking stage. GCC 
linker (that is used in x86_64-pc-windows-gnu Rust) fails with 
"undefined reference to `getuid'".


> 
> [...] 
>
-- 
-Alex