[rfc][icedtea-web] improved home finding to use variables first

[Alex Kashchenko]

On 12/07/2018 06:29 PM, jiri Vanek wrote:
> 
> [...]
>
>> I am talking about the warnings in a launcher code, currently (without
>> the patch) there are 11 warnings. They are all harmless ("dead_code"
>> type), but they produce a lot of garbage output that makes it easy to
>> miss possibly important new ones. It should be trivial to suppress
>> harmless warnings with #[allow(dead_code)],
>> #[allow(non_camel_case_types)] and similar annotations.
> 
> Interesting. That is not what I do see.  [1]

You are likely using newer version of Rust than me.

> 
> [...]
>
> 
> 6 times same: #[warn(dead_code)], leading from constant never used.
> All those constants will be used in future development or removed.

Until that time these constants may be annotated to not produce warnings.

> So you can not say that there are any real warnings right now. 

I suggest fixing/suppressing all the warnings in existing code.

> On contrary the new implementation of get_home is bringing many nasty warnings :(

I suggest fixing/suppressing all the warnings in new get_home.


> [...]
>

-- 
-Alex