Error Compiling ITW on Windows/Eclipse because of Byte Order Mark

[Jiri Vanek]

On 12/12/18 6:24 PM, jtesdall wrote:
> Jiri Vanek wrote
>> On 12/10/18 6:47 PM, jtesdall wrote:
>>> Compiling ITW on Eclipse for Windows gives an error on proximate line 632
>>> of
>>> nanoxml\XMLElement.java because of a bad character string checking for a
>>> byte order mark. I have changed this to an escape sequence to be able to
>>> compile. This also caused problems in debugging if I just excluded it
>>> from
>>> compilation, it needed fixed to debug.
>>>
>>> Before:
>>> if (ch == '') {
>>>
>>> After:
>>> if (ch == '\uFEFF') {
>>>
>>
>> It could hapen that your windows did not understand weird utf character.
>> One would hope such issues
>> already disapeared....
>>
>> Are you using tagsoup or not?
>>
>> -- 
>> Jiri Vanek
>> Senior QE engineer, OpenJDK QE lead, Mgr.
>> Red Hat Czech
> 
>> jvanek@
> 
>>     M: +420775390109
> 
> If by using Tagsoup you mean I am including it in the VM args then yes:
> D:\Downloads\Java-OpenJDK\IcedTea-Web\icedtea-web-1.7.1.win.bin\icedtea-web-1.7.1-image/win-deps-runtime/tagsoup.jar;
> 
> I don't really know what that library does, just that I need to include it.
> 
> Should this be included as a bug or fix to ITW? Changing to '\uFEFF' allows
> it to compile with Eclipse/Windows, I assume it will work with other configs
> as well. If you tell me how to submit this appropriately I will.

That is a bug and shoudl be fixed. Imho yours fix is good.
I have created for you: https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3671 and will get it
fixed.

Will it not colide with your current work? But that is liekly easy to fix.

Would be nice to have some test for this case:(

Thanxz!
> 
> 
> 
> 
> --
> Sent from: http://openjdk.5641.n7.nabble.com/OpenJDK-Distribution-specific-Packaging-f25548.html
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109