[rfc][icedtea-web] add classapth resolving to rust lunchers (and thus make them work)

Jiri Vanek jvanek at redhat.com
Tue Dec 18 11:44:08 UTC 2018


Nit. I  Forget about
TAGSOUP_JAR  and RHINO_JAR.

Straightforward to add.
J.
On 12/14/18 3:32 PM, Jiri Vanek wrote:
> Hello!
> 
> Here is huge patch which is making rust launchers finally possible. Unluckily it does several things
> at once. I will be happy to split them as reviewer requests. Maybe some of them (like javaws.jar)
> requires special discussion.
> 
> * makfile+java:
> - changed name of netx.jar to javaws jar
>   - properly used macros all over makefile.am
> configure:
> - introduced configure switch --with-itw-libs which determines if you build portable or distribution
> result. The goal is to achieve, that you can coexists  system itw, and in parallel custom portable
> instance by default, without fear of interference. Still the libraries order can be changed in
> runtime pretty much.
> * rust
> - inlcuded laoding of ITW_LIBS in compile time, propagating all jars so they can be reusable. Ketp
> xboothclassapth propagated to, but is use donly in debug output.
> - new module jars_helper is here to try to search for resources based  on ITW_LIBS and locations
> where deps are (we currently have windows and linux dirs named differently). About the members and
> order of LOCAL_PATH, I have many concerns. The current one is most free one.
>   - persisted the error of javafx being on normal classapth. Shouldnt it be on bootclassapth? (see
> nashorn around same lines) and see
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2018-November/040492.html)
>   - added method which composes cp/bootcp from freshl located members and from java resources (jdk8
> and down only!)
> - main method made aware of this classpaths and so it it is included in params for
> os.spawn_java_process together with main method and  custom arguments from cmdline and ...
>   ***fanfares*** IT WORKS ***fanfares***
> - os dependent modules got : x ; classpathDelimiter
> - moved  TestLogger to utils - is now shared.
> 
> So this patch, in is making  rust lunchers to do something. Is there something missing/redundant in
> this todo list?
> todo:
>   -J arguments
>   splash (+headless)
>   LAUNCHER_FLAGS=-Xms8m (?)
>   file logging
>   jdk from path(I dont know how to make it properly)
>   jdk9+ support (--patch/--add*)
>   jdk9+ support (rt.jar, fxrt.jar, nashorn.jar)
> 
> Thanx!
>   J.
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109


More information about the distro-pkg-dev mailing list