macOS xdg-desktop-icon

[Jiri Vanek]

On 11/27/18 6:24 PM, jtesdall wrote:
> Yes it was me that mentioned the uninstall in add\remove programs. I have
> went ahead and bitten the bullet and pulled down the source and begun adding
> in code to create the windows desktop shortcuts. I have that working now in
> a hardcoded fasion and need to make it dynamic by the actual application

That is awesome!
Looking forward for the patch.

> that is being handled. I will then take a look at making the "purge" clear
> cache function remove the desktop shortcut, as well as think about adding an
> item in add/remove programs. Jiri mentioned this is "nearly" not neccesary.

Please do this as separate chnageset. This may affect linux part to.

> That is true for techincal people but for standard windows users they have
> no concept of "cache" and expect to use add/remove programs to "uninstall" a
> program. I agree this isn't as critical as is a desktop shortcut but it
> would be nice to have.

I agree. Still this sounds like even bigger chnage, so as third chnageset. You may notice, that
there is button in itweb-settings - show desktop and menu integration window - which is disabled in
windows as "linux specific".

Maybe you can create similar window, which will handle  desktop icons lcean up + cache handling?
(==application removal).
Again, this should be (at least) fourth changeset.

> 
> I will be happy to share my code of course but have no idea of the process

Process is simple, jsu send patch - hg diff - to this list as [rfc][icedtea-web] added support for
windows desktop integration (or something like that). I will review , probably integrate, and
possibly make several turns of this patch. Then push for you.

> involved to do so. Nor do I have the knowledge of the standard ITW structure
> to make sure linux (xdesktop) still works, not do I have linux or mac.

It do not work on mac afaik :(

I will be happy to review the patches, and catch itw-lack-of-knowledge parts. Also I will be happy
to test your patches on linux. As You will be mostly playing in new, sister class of  our
XDesktopEntr( probably we should implement some new , shared, interface (not yet existing)),  and
thus your changes will be very isolated.
> Actually I have commented out some of the xdesktop code currently. If

ugh

> someone (Jiri ;0)) would like to take my windows code and integrate it

by order!

> properly that would be great. Otherwise I should keep it to myself for fear
> of messing things up and making more work for others.

Sure. Sounds like a plan.

Thanx!
  J.
> 
> 
> 
> --
> Sent from: http://openjdk.5641.n7.nabble.com/OpenJDK-Distribution-specific-Packaging-f25548.html
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109