[rfc][icedtea-web] refactored properties loader to be reusable
Alex Kashchenko
akashche at redhat.com
Fri Nov 30 16:40:57 UTC 2018
Hi,
On 11/30/2018 11:40 AM, Jiri Vanek wrote:
> On 11/29/18 7:14 PM, Alex Kashchenko wrote:
>> Hi,
>>
>> On 11/29/2018 11:35 AM, Jiri Vanek wrote:
>>>
>>> [...]
>>>
>>> Hello!
>>>
>>> All should be fixed, unless it leadked to much form refactroing.
>>
>> I assume verify_jdk_string should take &str, not &String? Any particular reason it uses &String?
>
> Nope. fixed.
>
> [...]
>
refactoredProperties3.patch and
usingRefactoredProeprtiesToLoadVerboseFromSettings2.patch look good to me.
--
-Alex
More information about the distro-pkg-dev
mailing list