[rfc][icedtea-web] enabled verbose switch for rust lunchers

Alex Kashchenko akashche at redhat.com
Mon Oct 1 23:12:21 UTC 2018


Hi,

On 10/01/2018 04:25 PM, Jiri Vanek wrote:
> 2018-10-01  Jiri Vanek <jvanek at redhat.com>
> 
>      * rust-launcher/src/main.rs: new method of (is_debug_on) based on 
> cmd line determining verbosity. (main) return of is_debug_on used for  
> os_access::Linux::new call.

If I understand the logic correctly, no actual arguments processing is 
planned inside the launcher - it just passes the arguments to ITW. Thus 
instead of using something like:

./javaws launcher_arg1 launcher_arg2 -- itw_arg1 itw_arg2

to specify launcher arguments explicitly, ITW arguments are just 
"sniffed" by the launcher.

I think inside "is_debug_on" it should be:

for s in env::args() {

Besides that, looks good to me.

-- 
-Alex


More information about the distro-pkg-dev mailing list