[rfc] [icedtea-web] Fix EDT hanging on OpenJDK 11

Mario Torre neugens at redhat.com
Tue Oct 2 09:37:57 UTC 2018


On Tue, Oct 2, 2018 at 10:56 AM Laurent Bourgès
<bourges.laurent at gmail.com> wrote:
>
> Hi,
>
>>
>> The patch is pushed to both head and 1.7
>
>
> Excellent, I will upgrade my local copy.
>
>>
>> During the applying, I noticed following:
>> ThreadCheckingRepaintManager was returned, however is unused.  Is that intentional?
>> Together with it, acordingly, +    private static final boolean DEBUG_EDT =
>> System.getProperty("icedtea-web.edt.debug", "false").equalsIgnoreCase("true"); was removed.
>>
>> I think one without another do not have sense. I would vote for make it enable-able. If not then it
>> should be removed, as it is now dead code.
>
>
> I can restore its optional usage ( DEBUG_EDT ) byresurecting SwingUtils.setup() if you want.
>
>>
>> Is the next step to rmeove ThreadCheckingRepaintManager or  to make it anebale-able?
>
>
> I will re-enable it if you and Mario agree.

I'm not sure what Jiri means by "re-enable", it should not be the
default imho, however this is his call really ;)

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898


More information about the distro-pkg-dev mailing list