[rfc][icedtea-web]detecting jre in rust lunchers

Alex Kashchenko akashche at redhat.com
Tue Sep 4 22:00:20 UTC 2018


Hi Jiri,

On 08/14/2018 05:00 PM, Jiri Vanek wrote:
> 
> [...]
> 
> The patch is adapted to most of the issues you rebuked.

The patch looks good to me, sorry for the delay.

I suggest fixing a couple of typos (main.rs: "usi(n)g", property.rs: 
"bo(u)nds") before the push.

> 
> [...]
>
>> inside Property::fmt write result is not checked (possibly 
>> intentionally omitted?).
> Hmm. Yes. Even example in doc.rust-lang do so.  What kind f check do you 
> suggest? What it would be for?

Nevermind, I missed the fact that result is returned from that method.


-- 
-Alex


More information about the distro-pkg-dev mailing list