[rfc] [icedtea-web] Fix EDT hanging on OpenJDK 11

[Jiri Vanek]

On 9/11/18 3:11 PM, Jiri Vanek wrote:
> On 9/11/18 2:46 PM, Laurent Bourgès wrote:
>> Jiri & Mario,
>>
>> Here is my final patch (after merging with backports):
>> http://cr.openjdk.java.net/~lbourges/itw/patch_EDT.log.3
>>

Except:
> I'm applying and writing chnagelog. Will push any moment.
> Do you have some issues with making
>     static abstract class FutureResult
> private?


One more nit crossed my mind.

You call  public static void setup()  on few places. Isnt safer to move SwingUtils to singleton, so 
the setup is called automagically during first call? Feel free to disagree. It hasve strong cost in 
code length, readability and usefulness of production code, to avoid setup for debug-only code...


Nit - there was -import javax.swing.JWindow  inb netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java. 
it disapeared. I will remove it again.
> 
> 
> looking forward for tip version for head and other patches. In meantime, I will nominate you for 
> push access.
> 
> J.
>>
>> Le mar. 11 sept. 2018 à 08:48, Laurent Bourgès <bourges.laurent at gmail.com 
>> <mailto:bourges.laurent at gmail.com>> a écrit :
>>
>>     Jiri,
>>
>>
>>          >     Please note http://icedtea.classpath.org/hg/icedtea-web/rev/5290684409aa it will
>>         interact with the
>>          >     patch for bleeding edge.  Maybe it is worthy to backport it to 1.7 and to adapt your
>>         patch on
>>          >     top of it?
>>          >
>>          >
>>          > Please backport to 1.7.
>>         done. Plus few more.
>>         Head and 1.7 are now very very similar. All except rust launchers.
>>
>>
>>     Thanks a lot, I merged and it works well.
>>
>>
>>          > I merged so the patch should not have these changes after backport:
>>
>>         So your patch now do not apply correctly, but the two rejected hunks can be happily
>>         ignored/removed.
>>         Feel free to provide updated version, but not necessary.
>>
>>
>>     I agree you should just ignore changes to JNLPRuntime.
>>     I can post an updated patch for tracability ?
>>
>>
>>          > I tested again and both 'javaws -viewer' and itw-settings dialogs are OK.
>>          >
>>
>>         Nothing more on my nitpicking list. Unless you or Mario will bring some news tomorrow, I
>>         will apply
>>         it to 1.7 and will look forward for patch for head, and other patches.
>>
>>
>>     Excellent: my first patch is accepted.
>>
>>         Note, that I'm on vacation 13-23.9, and I will be a bit delayed with replies. Lets guess a 
>> week
>>         delayed :)
>>
>>
>>     Enjoy holidays, I will have more time to improve shell scripts.
>>     Probably I will setup an ITW mirror on github following your instructions (license...).
>>
>>
>>         I will write an changelog on your behalf. If you wish to write it on your own, feel free.
>>
>>
>>     I can review the update to the change log...
>>
>>     Laurent
>>
>>
>>
>> -- 
>> -- 
>> Laurent Bourgès
> 
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109