[rfc] [icedtea-web] Fix EDT hanging on OpenJDK 11

[Jiri Vanek]

On 9/11/18 4:05 PM, Laurent Bourgès wrote:
> Jiri,
> 
> Le mar. 11 sept. 2018 à 15:48, Jiri Vanek <jvanek at redhat.com <mailto:jvanek at redhat.com>> a écrit :
> 
>     On 9/11/18 3:11 PM, Jiri Vanek wrote:
>      > On 9/11/18 2:46 PM, Laurent Bourgès wrote:
>      >> Jiri & Mario,
>      >>
>      >> Here is my final patch (after merging with backports):
>      >> http://cr.openjdk.java.net/~lbourges/itw/patch_EDT.log.3
>      >>
> 
>     Except:
>      > I'm applying and writing chnagelog. Will push any moment.
>      > Do you have some issues with making
>      >     static abstract class FutureResult
>      > private?
> 
> 
> No problem, it is already 'package' protected.
> Note: making it private may induce generating private accessors (by javac) for other inner classes 
> (Runnable).
> 
> 
>     One more nit crossed my mind.
> 
>     You call  public static void setup()  on few places. Isnt safer to move SwingUtils to singleton, so
>     the setup is called automagically during first call? Feel free to disagree. It hasve strong cost in
>     code length, readability and usefulness of production code, to avoid setup for debug-only code...
> 
> 
> I propose to defer such change to my follow-up patch (global SwingUtilities/EventDispatcher replaced 
> by SwingUtils), if you agree.

Yes. Deffinitly. But as I worite about five minutes later (sorry). Most likely better to not do that 
at all (the singleton)

Thanx a lot!
   J.
> 
>     Nit - there was -import javax.swing.JWindow  inb
>     netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java.
>     it disapeared. I will remove it again.
> 
> 
> 2 useless imports are in JNLPRuntime:
> --- a/JNLPRuntime.java
> +++ b/JNLPRuntime.java
> @@ -20,7 +20,6 @@
> 
>   import java.awt.EventQueue;
>   import java.awt.GraphicsEnvironment;
> -import static java.awt.GraphicsEnvironment.isHeadless;
>   import java.awt.HeadlessException;
>   import java.io.File;
>   import java.io.FileInputStream;
> @@ -51,7 +50,6 @@
>   import javax.net.ssl.SSLSocketFactory;
>   import javax.net.ssl.TrustManager;
>   import javax.swing.JOptionPane;
> -import javax.swing.JWindow;
>   import javax.swing.UIManager;
>   import javax.swing.text.html.parser.ParserDelegator;
> 
>      >
>      >
>      > looking forward for tip version for head and other patches. In meantime, I will nominate you for
>      > push access.
> 
> 
> Thanks, do you want me to prepare the patch for 1.8 ?
> 
> Laurent


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109