[rfc] [icedtea-web] Fix EDT hanging on OpenJDK 11

[Laurent Bourgès]

Jiri,

Could you push on 1.7 so I will prepare new patches during your holidays ?

Mario, do you approve or not ?

Cheers,
Laurent

Le mar. 11 sept. 2018 à 17:15, Laurent Bourgès <bourges.laurent at gmail.com>
a écrit :

> Jiri,
>
> Few syntax changes:
>
>>
>>         Fixed EDT hanging
>>         * AUTHORS: added Laurent
>>         * netx/net/sourceforge/jnlp/GuiLaunchHandler.java: invokeLater
>> and invokeAndWait moved from
>> SwingUtilities local wrapper of SwingUtils.
>>
> => invokeLater and invokeAndWait moved from SwingUtilities to the local
> wrapper SwingUtils.
>
>>         Simplified splasshcreen loading
>>
> => splashscreen
>
>>         * netx/net/sourceforge/jnlp/JNLPSplashScreen.java: added name to
>> the dialog
>>         * netx/net/sourceforge/jnlp/Launcher.java: added log entry for
>> main class loading. Highlighted
>> usage of SwingUtilities on top SwingUtils
>>         for this particular space
>>
> => Highlighted usage of SwingUtilities instead of SwingUtils for this
> particular case
>
>>         * netx/net/sourceforge/jnlp/about/AboutDialog.java: added name.
>> Highlighted usage of
>> SwingUtilities on top SwingUtils
>>         for this particular space
>>
> => invokeLater and invokeAndWait moved from SwingUtilities to the local
> wrapper SwingUtils.
>
>>         * netx/net/sourceforge/jnlp/cache/DefaultDownloadIndicator.java:
>> reworked to work in
>> SwingUtils.invokeAndWait. Added name.
>>         *
>> netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java:
>> added name
>>         * netx/net/sourceforge/jnlp/controlpanel/CacheViewer.java: added
>> name
>>         * netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java: added
>> top level setup for enabling
>> SwingUtils debugging abilities
>>         added log entry for main class loading. Highlighted usage of
>> SwingUtilities on top SwingUtils for
>> this particular space
>>
> => Highlighted usage of SwingUtilities instead of SwingUtils for this
> particular case
>
>>         * netx/net/sourceforge/jnlp/runtime/Boot.java: added top level
>> setup for enabling SwingUtils
>> debugging abilities
>>         CertificateViwer moved to invokeAndWait. added log entry for main
>> class loading. Highlighted usage
>> of SwingUtilities on top SwingUtils
>>         for this particular space.
>>
> => Highlighted usage of SwingUtilities instead of SwingUtils for this
> particular case
>
>>         * netx/net/sourceforge/jnlp/runtime/HtmlBoot.java:invokeLater and
>> invokeAndWait moved from
>> SwingUtilities local wrapper of SwingUtils
>>
> => invokeLater and invokeAndWait moved from SwingUtilities to the local
> wrapper SwingUtils.
>
>>         * netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java: removed
>> import of import javax.swing.JWindow
>>
> =>  removed import javax.swing.JWindow
>
>>         * netx/net/sourceforge/jnlp/runtime/JNLPSecurityManager.java:
>> direct call to JWindow().getOwner(),
>> moved to  SwingUtils.getOrCreateWindowOwner.
>>         Its existence doubtful
>>         * netx/net/sourceforge/jnlp/security/SecurityDialog.java:
>> installPanel moved to invokeAndWait
>>         * netx/net/sourceforge/jnlp/security/SecurityDialogs.java: used
>> SwingUtils instead of
>> SwingUtilities, added name
>>         * netx/net/sourceforge/jnlp/security/dialogs/ViwableDialog.java:
>> swing ops moved to invokeAndWait
>>         *
>> netx/net/sourceforge/jnlp/security/viewer/CertificateViewer.java: calling
>> Swingutils.setup,
>> astill al the same
>>
> => all still the same ?
>
>>         *
>> netx/net/sourceforge/jnlp/splashscreen/impls/defaultsplashscreen2012/BasePainter.java:
>> still the same
>>         * netx/net/sourceforge/jnlp/util/BasicExceptionDialog.java: same
>> - name, SwingUtils x
>> SwingUtilities, and proepr usage of invokes
>>
> => proper
>
>>         * netx/net/sourceforge/jnlp/util/FileUtils.java: SwingUtils x
>> SwingUtilities
>>         * netx/net/sourceforge/jnlp/util/logging/JavaConsole.java:
>> observable.notifyObservers moved to
>> invokeLater and
>>         and invoked only if observable.hasChanged
>>         * netx/net/sourceforge/swing/SwingUtils.java: new class. Wrapper
>> around most commonly used
>> SwingUtilities calls. Add debugging bridge
>>         property of icedtea-web.edt.debug set to true, can enable it on
>> runtime.
>>         * netx/net/sourceforge/swing/ThreadCheckingRepaintManager.java:
>> Based on
>>
>> http://weblogs.java.net/blog/alexfromsun/archive/2006/02/debugging_swing.html
>>         debugging repaint manager
>>         * netx/net/sourceforge/swing/TracingEventQueue.java: new class to
>> debug EDT - showing very long
>> event processing (hanging or EDT blocked ?)
>>
>
>  Except typos, it is good for me.
>
> Laurent
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20180913/e05017cf/attachment.html>