[rfc] [icedtea-web] Fix EDT hanging on OpenJDK 11

[Mario Torre]

On Thu, Sep 13, 2018 at 1:04 PM Laurent Bourgès
<bourges.laurent at gmail.com> wrote:
>
> Mario,
>
>> > Mario, do you approve or not ?
>>
>> Hi Laurent,
>>
>> Just a little bit of patience, I asked for a second opinion, and I'm
>> not so familiar with the rest of the code base so I took some more
>> time to get around it.
>
>
> No problem, I didn't want to stress you.
> Let's wait for Jiri to come back from holidays.

No worries, I just wanted to be sure you understood we are working on
it, I get that sometime with reviews things take longer than desired
which can be a bit frustrating.

> I can improve that to defer also the installPanel() method until show() using a new method to queue the getPanel(this) ...
> but it could have side-effect ? so I just wrap that call for now.

Sure, let's revisit later then.

> Good idea, I also checked all ViwableDialog method usages and it is OK for now.

Cool, thanks.

>> Regarding the SwingUtils, I'm not happy about installing those repaint
>> managers, although I understand this is for debug only.
>
>
> Ok, I propose to remove the 2 other classes and keep them on my side, if I need to debug it again in the future.

Yes, thanks, users can do the same if they need to debug the EDT (as
we can do too).

> It is not in my patch but in current code base.
> Another example: ViwableDialog should be ViewableDialog ?

Ops, you are right. If you don't mind fixing this line while we're
there, otherwise just let it be and we'll go over another time.

> OK, I will improve my patch:
> - add SwingUtils.callOnAppContext()
> - rewrite the installPanel() tricky part

Thanks!

I don't need another review unless the patch changes substantially (or
if you want me to go through your new changes for installPanel), if
Martin approves you can push directly (or we'll wait for Jiri if you
don't have push rights).

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898