[rfc][icedtea-web]enable view of whole control settings from javaws --viewer

[Laurent Bourgès]

Jiri,
that seems straightforward, thanks.

I would prefer having my pending EDT patch integrated, then move on other
patches and provide new features on a good basis.

Laurent

Le jeu. 27 sept. 2018 à 10:24, Jiri Vanek <jvanek at redhat.com> a écrit :

> On 9/26/18 8:44 PM, Laurent Bourgès wrote:
> > Jiri,
> > I had a quick look and it is a good improvement.
> >
> > I wonder how it fits / is in conflict with my patch on EDT under review.
> >
> > I will have a deeper look later at dispose() & edt related stuffs.
>
> Yes. it conflicts at:
> ./netx/net/sourceforge/jnlp/runtime/Boot.java
> ./netx/net/sourceforge/jnlp/security/viewer/CertificateViewer.java
> ./netx/net/sourceforge/jnlp/security/SecurityDialog.java
>
> Oviously, the:
>    CertificateViewer.main(null);
> -                JNLPRuntime.exit(0);
> +                SwingUtils.invokeAndWait(new Runnable() {
> +                    @Override
> +                    public void run() {
> +                        CertificateViewer.showCertificateViewer();
> +                    }
> +                });
>               } catch (Exception e) {
>
> Even if I wrap it now to SwingUtilities,invokeAndWait, it will still
> colide with SwingUtils later.
>
>
>          super((Frame) null, dialogTitle, true);
> +        this.setName("CertificateViewer");
> +        SwingUtils.info(this);
>
> First line had changed. Even if I add name, will still colide with
> SwingUtils.info(this);
>
> import javax.swing.JDialog;
> +import net.sourceforge.swing.SwingUtils;
> It is no longer iport fromjdiaolg, but from Window.
>
>
> I can wait with this patch until EDT fix is pushed to both head and 1.7 .
> It is up to you.
>
> https://icedtea.classpath.org/wiki/IcedTea-Web#IcedTea-Web_1.8 aligned
> accordingly.
>
>
> >
> > Laurent
> >
> > Le mer. 26 sept. 2018 à 19:22, Jiri Vanek <jvanek at redhat.com <mailto:
> jvanek at redhat.com>> a écrit :
> >
> >     SSIA
> >     --
> >     Jiri Vanek
> >     Senior QE engineer, OpenJDK QE lead, Mgr.
> >     Red Hat Czech
> >     jvanek at redhat.com <mailto:jvanek at redhat.com>    M: +420775390109
> >
>
>
> --
> Jiri Vanek
> Senior QE engineer, OpenJDK QE lead, Mgr.
> Red Hat Czech
> jvanek at redhat.com    M: +420775390109
>


-- 
-- 
Laurent Bourgès
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20180927/78c42def/attachment.html>