[PATCH][icedtea][RFC] Don't hard link sources from --with-openjdk-src-dir

[Daniel Santos]

Hard-linking sources results in the original source tree being modified,
which can be a nasty surprise.  This patch provides the simplest
solution, which is to not link them.

There are other solutions, however.  I have another patch that provides
a --disable-patching configure option that inhibits all modifications to
OpenJDK sources (fsg.sh, remove-intree-libraries.sh and patches).  This
made it much easier to use Icedtea as the harness while developing
OpenJDK patches for my target.

2019-04-03  Daniel Santos  <daniel.santos at pobox.com>

	* acinclude.m4,
	* Makefile.am:
	(OPENJDK_SRC_DIR_HARDLINKABLE): Remove.
	(OPENJDK_SRC_DIR_LINK): Likewise.

Signed-off-by: Daniel Santos <daniel.santos at pobox.com>
---
 Makefile.am  |  8 +-------
 acinclude.m4 | 11 -----------
 2 files changed, 1 insertion(+), 18 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 166e1696..aed5a645 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -288,12 +288,6 @@ if CP_SUPPORTS_REFLINK
   REFLINK = --reflink=auto
 endif
 
-if OPENJDK_SRC_DIR_HARDLINKABLE
-  OPENJDK_SRC_DIR_LINK = -l
-else
-  OPENJDK_SRC_DIR_LINK = $(REFLINK)
-endif
-
 if !DISABLE_HOTSPOT_TESTS
 HOTSPOT_TEST_SUITE = hotspot
 endif
@@ -1282,7 +1276,7 @@ clean-extract: clean-extract-openjdk clean-extract-cacao clean-extract-jamvm
 
 stamps/extract-openjdk.stamp: stamps/download-openjdk.stamp
 if OPENJDK_SRC_DIR_FOUND
-	cp -pPR $(OPENJDK_SRC_DIR_LINK) $(OPENJDK_SRC_DIR) openjdk
+	cp -pPR $(OPENJDK_SRC_DIR) openjdk
 else
 if USE_HG
 	$(HG) clone $(REV_ARG) $(ICEDTEA_HG_URL) openjdk;
diff --git a/acinclude.m4 b/acinclude.m4
index 6c9abf0f..d5edad8e 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -316,19 +316,8 @@ AC_DEFUN_ONCE([IT_WITH_OPENJDK_SRC_DIR],
       with_external_src_dir=false
     fi
     AC_MSG_RESULT(${openjdk_src_dir_valid})
-    if test "x${openjdk_src_dir_valid}" = "xyes"; then
-      AC_MSG_CHECKING([if we can hard link rather than copy the OpenJDK source directory])
-      if cp -l ${OPENJDK_SRC_DIR}/README tmp.$$ >&AS_MESSAGE_LOG_FD 2>&1; then
-        openjdk_src_dir_hardlinkable=yes;
-      else
-        openjdk_src_dir_hardlinkable=no;
-      fi
-      AC_MSG_RESULT(${openjdk_src_dir_hardlinkable})
-      rm -f tmp.$$
-    fi
   fi
   AM_CONDITIONAL(OPENJDK_SRC_DIR_FOUND, test "x${with_external_src_dir}" = "xtrue")
-  AM_CONDITIONAL(OPENJDK_SRC_DIR_HARDLINKABLE, test "x${openjdk_src_dir_hardlinkable}" = "xyes")
 ])
 
 AC_DEFUN([IT_FIND_ECJ_JAR],
-- 
2.19.2