Update on Windows shortcut features for ITW

[Jiri Vanek]

Hi !

Thank you very much for contribution. I will start a work on it and try to incorporate before
january 15. But I'm a bit sceptic if the date will fit for you. I can probably promise to have it
pushed within those 14 days to tip, but backport to 1.7 is unlikely.
What is your opinion about it?

Thanx a lot!
  zip dowloaded
   J.

On 12/26/18 7:15 PM, jtesdall wrote:
> I have my changes complete for now. I have attached a zip file with my
> changed .java classes and the new mslinks.jar needded to create windows
> shortcuts. I have also included the original unchanged source code in the
> original directory.
> 
> MAPCONIcedTeaSRCChanges.zip
> <http://openjdk.5641.n7.nabble.com/file/t3943/MAPCONIcedTeaSRCChanges.zip>  
> 
> Jiri, you may want to change the way I have done some things as it pertains
> to ITW. What I have seems to work well though. I have done quite a bit of
> testing and will be doing substantially more in the coming weeks in my
> office. I am hoping to have this in production by Jan 15th. Would you please
> do whatever is needed to submit these as changesets and test on linux to
> make sure I didn't break anything there?
> 
> Note: The reason my netx.jar would not work after copying in boot.class is
> that the jar struccturre had changed at some point and added a whole
> directory of classes net\sourceforge\swing. Once I copied in those classes I
> could create a my own jar by replacing classes once again.
> 
> Here is what I have done as it pertains to each class:
> 
> *changed in runtime\ApplicationInstance.java*
> many changes to add windows shortcut to desktop and add Start menu item
> taken from JNLP. This menu has the app shortcut and an uninstall shortcut.
> added new library mslinks to create windows shortcuts since they are in a
> binary format.
> favicon.ico from apps root is downloaded and cached and used for shortcut
> ico, if none is present it will not have a pretty icon
> 
> *changed in cache\CacheUtil.java*
> added code to delete shortcut and menu subdir in clearcache
> added overload function for clearcache to delete one app at a time from
> cache instead of clearing the whole thing
> 
> *changed in runtime\Boot.class*
> added code to allow passing a parameter to -xclearcache with parameter of
> jnlpPath to remove one app from cache. This was needed to allow a Windows
> App uninstall shortcut. If no parameter is passed all of the chache is
> cleared as was normal before my change. This was done in init function.
> 
> *changed in cache\ResourceDownloader.class* 
> add new parameter jnlpPath to .info file so files can be found by jnlp. This
> allows clearcache to mark one applications files for deletion so a later
> call to cleancache works and actually deletes the files correctly.
> added these lines String jnlpPath =
> JNLPRuntime.getInitialArguments().get(1).toString();
> entry.setJnlpPath(jnlpPath);
> 
> *changed in cache\CacheEntry.class*
> added setJnlpPath(jnlpPath) function to add jnlpPath to .info files as
> needed by ResourceDownloader above.
> 
> *changed in resources\Messages.properties*
> improved english for some messages
> 
> 
> 
> 
> 
> 
> --
> Sent from: http://openjdk.5641.n7.nabble.com/OpenJDK-Distribution-specific-Packaging-f25548.html
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109