[rfc][icedtea-web] add classapth resolving to rust lunchers (and thus make them work)

[Alex Kashchenko]

On 1/8/19 4:56 PM, Jiri Vanek wrote:
>
> [...]
>
>>>>>> configure:
>>>>>> - introduced configure switch --with-itw-libs which determines if you build portable or
>>>>>> distribution
>>>>>> result. The goal is to achieve, that you can coexists  system itw, and in parallel custom portable
>>>>>> instance by default, without fear of interference. Still the libraries order can be changed in
>>>>>> runtime pretty much.
>>
>> Is it possible to add auto-detection here to default to BUNDLED on windows? It would be great if
>> "bash configure" without args continue working on windows.
> 
> done
>>
>> Also currently check_config_files_paths test is failing on windows, I suggest adding
>> #[cfg(not(windows))] to it.
> 
> done

Thanks, full build works for me now.


>
> [...]
>
>> 3. in resolve_jar get_libsearch is called multiple times, shouldn't it be called only once?
> 
> In this case, I do not see difference between calling method twice, or declaring variable can
> reusing this result. So kept. I will fix if you insists.

get_libsearch calls env::var that incurs a call to getenv in libc. And 
it is called 4 times there for no obvious reason. I suggest to change 
this to 1 call.


>>
>> [...]
>>
>> 7. in compose_class_path,
>>
>> while i != members.len()
>>
>> should be written as:
>>
>> for (i, mb) in members.iter().enumerate()
> 
> done. Thanx!

&members[i] needs to be changed to mb.

Besides these things patch looks good to me.


>
> [...]
>



-- 
-Alex