[rfc][icedtea-web] rust launcher made able to find JRE from path

Alex Kashchenko akashche at redhat.com
Fri Jan 11 13:41:41 UTC 2019


Hi,

On 1/10/19 2:17 PM, Jiri Vanek wrote:
> On 1/10/19 3:07 PM, Jiri Vanek wrote:
>> This patch moving jre detection from main to utils.
>> I addition it is adding ability to scan path, and find jre on it, if the build is *not* distribution
>> one.

In get_jdk_from_path_conditionally it may be better to call 
get_libsearch only once.

In get_jdk_from_path - I suggest factoring it a bit, long closure three 
levels deep looks ugly.

Besides that patch is good to me.

>
> [...]
>
x

-- 
-Alex


More information about the distro-pkg-dev mailing list