prerelase of icedtea-web 1.8

Jiri Vanek jvanek at redhat.com
Thu Mar 7 08:16:05 UTC 2019


Thanx! Pushed
On 3/6/19 7:14 PM, Lars Herschke wrote:
> Hi Jiri,
> 
> I have tested your patch and it works for me with a little change.
> 
> I have changed the line
> [target.'cfg(windows)']
> in the Cargo.toml to
> [target.'cfg(windows)'.dependencies]
> 
> 
> 
> Mit freundlichen Grüßen
> 
> Lars Herschke
> 
> Data-Service GmbH
> Beethovenstraße 2a
> 23617 Stockelsdorf
> Amtsgericht Lübeck, HRB 318 BS
> Geschäftsführung: Wilfried Paepcke, Dr. Andreas Longwitz,
>                   Dr. Uwe Szyszka, Dr. Hans-Martin Rasch
> Tel. (0451) 49 00-188
> Fax. (0451) 49 00-123
> e-mail: lhersch at dssgmbh.de
> 
> 
> Jiri Vanek schrieb:
>> On 3/5/19 11:32 AM, Lars Herschke wrote:
>>> Hello,
>>>
>>> attached a patch that cause the following changes.
>>>
>>> acinclude.m4:
>>> - configure-switch --with-jdk-home acts on windows
>>>
>>> Makefile.am:
>>> - windows-fix for changeset 1565:7010aa9d9309
>>> - fixes for make clean with native plugin disabled
>>>
>>> rust-launcher:
>>> 1. Use cannonicalize from crate dunce, because std::fs:canonicalize
>>>    return on windows unc-paths like this \\?\C:\foo. This paths doesn't
>>>    work with spawn() from std::process::Command.
>>> 2. Correct path for jfxrt.jar
>>> 3. Use JRE-path instead of JDK-path from registry and don't panic if
>>>    this regkey doesn't exist, because jfxrt.jar, rt.jar and nashorn.jar
>>>    are only in the JRE-directory on openjdk. In addition users, that
>>>    have only installed JRE don't have the JDK-regkey in your registry.
>>>
>>>
>>
>> Hi Lars!
>>
>> Please eyball the attached patch. It should be handling the dunce as windows-only.
>>
>> J.
>>
> 


-- 
Jiri Vanek
Senior QE engineer, OpenJDK QE lead, Mgr.
Red Hat Czech
jvanek at redhat.com    M: +420775390109


More information about the distro-pkg-dev mailing list