[Bug 3838] New: [IcedTea8] Bogus -Wnonnull warning on Zero builds

[bugzilla-daemon at icedtea.classpath.org]

https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3838

            Bug ID: 3838
           Summary: [IcedTea8] Bogus -Wnonnull warning on Zero builds
           Product: IcedTea
           Version: 3.x-hg
          Hardware: all
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Zero
          Assignee: gnu.andrew at redhat.com
          Reporter: gnu.andrew at redhat.com
                CC: unassigned at icedtea.classpath.org

/usr/bin/g++ -DLINUX -D_GNU_SOURCE -DCC_INTERP -DZERO -DS390
-DZERO_LIBARCH=\"s390x\" -DPRODUCT 
-I/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm/prims
-I/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm
-I/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm/precompiled
-I/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/cpu/zero/vm
-I/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/os_cpu/linux_zero/vm
-I/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/os/linux/vm
-I/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/os/posix/vm
-I../generated -DHOTSPOT_RELEASE_VERSION="\"25.292-b10\""
-DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"mockbuild\""
-DHOTSPOT_LIB_ARCH=\"s390x\" -DHOTSPOT_VM_DISTRO="\"OpenJDK\""
-DDERIVATIVE_ID="\"IcedTea 3.19.0\"" -DDISTRIBUTION_ID="\"Built on Fedora
release 34 (Thirty Four) (Mon May 10 02:36:54 UTC 2021)\""  -g
-grecord-gcc-switches -pipe -Wformat -Wno-cpp -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=zEC12 -mtune=z13
-fasynchronous-unwind-tables -fstack-clash-protection -DTARGET_OS_FAMILY_linux
-DTARGET_ARCH_zero -DTARGET_ARCH_MODEL_zero -DTARGET_OS_ARCH_linux_zero
-DTARGET_OS_ARCH_MODEL_linux_zero -DTARGET_COMPILER_gcc -DINCLUDE_JFR=0
-DDONT_USE_PRECOMPILED_HEADER   -fno-rtti -fno-exceptions -D_REENTRANT
-fcheck-new -fvisibility=hidden -m64 -pipe -fno-strict-aliasing  -g
-fno-omit-frame-pointer -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_zero
-DTARGET_ARCH_MODEL_zero -DTARGET_OS_ARCH_linux_zero
-DTARGET_OS_ARCH_MODEL_linux_zero -DTARGET_COMPILER_gcc -DINCLUDE_JFR=0
-DDONT_USE_PRECOMPILED_HEADER  -fPIC -fno-rtti -fno-exceptions -D_REENTRANT
-fcheck-new -fvisibility=hidden -m64 -pipe -fno-strict-aliasing  -g
-fno-omit-frame-pointer -O3  -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare
-Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type  
-fstack-protector -g -grecord-gcc-switches -pipe -Wformat -Wno-cpp
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=zEC12 -mtune=z13
-fasynchronous-unwind-tables -fstack-clash-protection
-fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 
-DDTRACE_ENABLED -c -MMD -MP -MF ../generated/dependencies/compiledIC.o.d
-fpch-deps -o compiledIC.o
/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm/code/compiledIC.cpp 
/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm/code/compiledIC.cpp:
In member function 'void CompiledIC::set_to_monomorphic(CompiledICInfo&)':
/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm/code/compiledIC.cpp:406:30:
error: 'this' pointer is null [-Werror=nonnull]
  406 |       csc->set_to_interpreted(method, info.entry());
      |       ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
In file included from
/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm/code/compiledIC.cpp:28:
/builddir/build/BUILD/icedtea-3.19.0/openjdk/hotspot/src/share/vm/code/compiledIC.hpp:317:8:
note: in a call to non-static member function 'void
CompiledStaticCall::set_to_interpreted(methodHandle, address)'
  317 |   void set_to_interpreted(methodHandle callee, address entry);
      |        ^~~~~~~~~~~~~~~~~~

This occurs because csc is constructed from instruction_address():

CompiledStaticCall* csc = compiledStaticCall_at(instruction_address());

On Zero, instruction_address is not supposed to be called:

NativeCall*   _ic_call;       // the call instruction
address instruction_address() const { return _ic_call->instruction_address(); }

>From hotspot/src/cpu/zero/vm/nativeInst_zero.hpp:

  address instruction_address() const {
    ShouldNotCallThis();
    return NULL;

The call is in CompiledIC::set_to_monomorphic and instruction_address has
already been checked on construction:

CompiledIC::CompiledIC(nmethod* nm, NativeCall* call)
  : _ic_call(call)
{
  address ic_call = _ic_call->instruction_address();

  assert(ic_call != NULL, "ic_call address must be set");
...

Thus, the warning seems benign as the VM should never reach the point of trying
to invoke a method on this null pointer.
  }

This is also checked when

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20210512/be4b4672/attachment.htm>