Review request for present, directly present, etc. in core reflection javadoc

Alex Buckley alex.buckley at oracle.com
Fri Jul 12 10:03:56 PDT 2013


Looks good now.

On 7/11/2013 11:01 PM, Joe Darcy wrote:
> Hello,
>
> On 07/11/2013 03:35 PM, Alex Buckley wrote:
>> I am glad that getAnnotation(...), getAnnotations(), and
>> getAnnotationsByType(...) are now presented in that order.
>>
>> But I should have been clearer that this order also applies to
>> getDeclaredAnnotation(...), getDeclaredAnnotations(), and
>> getDeclaredAnnotationsByType(...). Each triple of methods has the same
>> natural order: legacy-legacy-new.
>
> Reordered.
>
>>
>> This also applies to the summary table:
>>
>> T            getAnnotation(Class<T>)
>> Annotation[] getAnnotations()
>> T[]          getAnnotationsByType(Class<T>  <-- missing ) in the webrev
>
> Fixed.
>
>> T getDeclaredAnnotation(Class<T>)
>> Annotation[] getDeclaredAnnotations()
>> T[]          getDeclaredAnnotationsByType(Class<T>)
>>
>> - Since the text in the Method column is monospaced, could it be
>> spaced as above, so that method names line up?
>
> I broke this up into two columns for display purposes.
>
>>
>> - Consider adding a column after Method: "Since". Column values: 1.5
>> 1.5 1.8 1.5 1.5 1.8.
>
> I think that would look dated very quickly.
>
> Patch below; webrev at
>
>      http://cr.openjdk.java.net/~darcy/8010679.3/
>
> Thanks,
>
> -Joe


More information about the enhanced-metadata-spec-discuss mailing list