RFR (S): GRAAL-213: add HotSpot-style PrintCompilation and PrintInlining

[Thomas Wuerthinger]

Looks good. Thanks, thomas

On Apr 10, 2013, at 10:37 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> 
> On Apr 10, 2013, at 8:47 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
>> 
>> On Apr 10, 2013, at 3:18 AM, Doug Simon <doug.simon at oracle.com> wrote:
>> 
>>> 
>>> On Apr 10, 2013, at 12:06 PM, Lukas Stadler <lukas.stadler at jku.at> wrote:
>>> 
>>>> Hi Christian,
>>>> 
>>>> looks good, but I see one problem:
>>>> We cannot have references to HotSpot-specific classes in the phases.common project.
>>> 
>>> I agree.
>> 
>> I missed that InliningUtil is in phases.common.
>> 
>>> 
>>>> Doing an "mx build" should fail, because this will compile the projects independently with the right dependencies.
>>>> Maybe you could add a flag to GraalOptions? Something like "PrintInliningDecisions"…
>>> 
>>> And GraalOptions.PrintInliningDecisions could be updated from the HotSpot specific option.
>> 
>> Will do that.
> 
> I made that change and updated the webrev:
> 
> http://cr.openjdk.java.net/~twisti/GRAAL-213
> 
> -- Chris
> 
>> 
>>> 
>>> BTW, I have an internal task (GRAAL-27) to rework GraalOptions to be more "distributed" so that options can be declared closer to where they are used and automatically discovered by the option parsing logic.
>> 
>> That sounds good.
>> 
>> -- Chris
>> 
>>> 
>>> -Doug
>>> 
>>>> On Apr 10, 2013, at 5:34 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>>> 
>>>>> http://cr.openjdk.java.net/~twisti/GRAAL-213
>>>>> 
>>>>> GRAAL-213: add HotSpot-style PrintCompilation and PrintInlining
>>>>> Summary:
>>>>> Reviewed-by:
>>>>> 
>>>>> COMMENTS
>>>>> 
>>>>> graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/CompilationTask.java
>>>>> graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/HotSpotVMConfig.java
>>>>> graal/com.oracle.graal.phases.common/src/com/oracle/graal/phases/common/InliningUtil.java
>>>>> src/share/vm/graal/graalCompilerToVM.cpp
>>>>> 
>>>> 
>>> 
>> 
>