final graal HSAIL support patch

Christian Thalinger christian.thalinger at oracle.com
Mon Jun 24 11:18:03 PDT 2013


On Jun 24, 2013, at 11:13 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> I've created a Graal tracking bug so it's easier for me to handle it (the bug is not visible outside of Oracle):
> 
> GRAAL-342: add HSAIL backend
> 
> Here is the new webrev:
> 
> http://cr.openjdk.java.net/~twisti/GRAAL-342/webrev/

Two quick comments:

1)  I understand that the way you're handling the assembler right now was much less work but I wonder if you ever want to go to support your binary format too.  Then a full-fledged assembler as for the other platforms might be better.

2)  The Labels.  I remember talking to Gilles about this when I did the PTX work and I think there is a better way of doing this (although I can't recall).

-- Chris

> 
> -- Chris
> 
> On Jun 19, 2013, at 3:27 PM, "Venkatachalam, Vasanth" <Vasanth.Venkatachalam at amd.com> wrote:
> 
>> Hi Christian,
>>  
>> Here’s the final version of our graal HSAIL support patch. This addresses all of Doug Simon’s comments.
>>  
>> In particular,
>>  
>> 1)      Checkstyle errors have been fixed and all licenses in the Okra packages are attributed to Oracle.
>> 2)      What was previously the com.amd.sumatra package has been removed and its source files (which don’t have anything Sumatra specific) have been moved into the com.oracle.graal.compiler.hsail package.
>> 3)      Hotspot c++ source changes have been reverted and are no longer part of the webrev.
>>  
>> Vasanth
>> <graal.patch>
> 



More information about the graal-dev mailing list