RFR (XXS): remove basicTypes and basicTypeCount

Doug Simon doug.simon at oracle.com
Sat May 4 14:42:31 PDT 2013


Looks fine to me.

I wonder how much other dead code there is in the Graal C++ layer? It must all go!

On May 4, 2013, at 6:55 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:

> [I'm not preparing a webrev for this one because it's trivial.]
> 
> http://hg.openjdk.java.net/graal/graal/rev/87e8baf5447c removed the usage of basicTypes and basicTypeCount.
> 
> diff --git a/src/share/vm/graal/graalCompilerToVM.cpp b/src/share/vm/graal/graalCompilerToVM.cpp
> --- a/src/share/vm/graal/graalCompilerToVM.cpp
> +++ b/src/share/vm/graal/graalCompilerToVM.cpp
> @@ -616,9 +633,6 @@
>   return id;
> }
> 
> -BasicType basicTypes[] = { T_BOOLEAN, T_BYTE, T_SHORT, T_CHAR, T_INT, T_FLOAT, T_LONG, T_DOUBLE, T_OBJECT };
> -int basicTypeCount = sizeof(basicTypes) / sizeof(BasicType);
> -
> C2V_ENTRY(void, initializeConfiguration, (JNIEnv *env, jobject, jobject config))
> 
> #define set_boolean(name, value) do { env->SetBooleanField(config, getFieldID(env, config, name, "Z"), value); } while (0)
> 



More information about the graal-dev mailing list