webrev for loading HSAIL/Okra function pointers

Doug Simon doug.simon at oracle.com
Fri Nov 22 08:40:11 PST 2013


Looks good to me - I’ll push it through.

On Nov 22, 2013, at 3:21 PM, Caspole, Eric <Eric.Caspole at amd.com> wrote:

> Hi everybody,
> Here is a webrev to do null checks on the Okra library we load to do the HSAIL offload. Earlier there were no checks on finding the function pointers, so if you happened to be running an older version of Okra from github, it would crash.
> 
> http://cr.openjdk.java.net/~ecaspole/check_okra_funcs/
> 
> Here I made the function pointer loading very similar to the PTX version using macros with null checks.
> Thanks,
> Eric
> 



More information about the graal-dev mailing list