webrev to remove AMD GPU check

Doug Simon doug.simon at oracle.com
Fri Nov 22 08:40:43 PST 2013


Looks good to me as well - I’ll push it through.

On Nov 22, 2013, at 4:59 PM, S. Bharadwaj Yadavalli <bharadwaj.yadavalli at oracle.com> wrote:

> This change looks good to me. I have successfully run a couple of PTX tests on a machine with Intel CPU + Nvidia GPU with this patch.
> 
> Thanks,
> 
> Bharadwaj
> 
> On 11/22/2013 09:13 AM, Caspole, Eric wrote:
>> Hi everybody,
>> After discussing it with Bharadwaj the other day, I made a webrev to remove AMD GPU detection since for the time being we are only running on the HSAIL simulator, which only depends on shared libraries. I found that since AMD CPUs and GPUs have the same vendor ID, this part was not working as intended if you have a system with an AMD CPU with Nvidia GPU so nothing would be offloaded. We will adjust this AMD APU detection when the real HSA system is generally available.
>> 
>>  http://cr.openjdk.java.net/~ecaspole/no_amd_hw_check/
>> 
>> In the course of this change, I moved the gpu::init during the JVM boot up after the arguments are processed so the +UseHSAILSimulator I added earlier will work correctly.
>> Let me know what you think,
>> Thanks,
>> Eric
>> 
> 



More information about the graal-dev mailing list