hsail test case failures in the latest tip, mathSubstitutions

[Deneau, Tom]

Doug or others --

Vasanth is out this week so I am trying to get the HSAIL backend working with this new infrastructure.

A specific problem we are having, previously we had a replacement for Math.sqrt(double) to MathSubstitutionsX86.sqrt(double) which was I think just inherited from AMD64HotSpotRuntime.  (In the HSAIL LIR and assembler then, we emitted the HSAIL instruction from the MathIntrinsicNode).

What is the right way to get just that one substitution working in the new framework?  (Once we get that working, we can then add additional substitutions as needed).

I can see that HSAILHotSpotReplacementsUtil needs some methods to be implemented (perhaps deferring to its parent), but for the substitution class itself, am not sure of whether new files should be created, or we should reuse existing MathSubstitutions.

-- Tom


-----Original Message-----
From: graal-dev-bounces at openjdk.java.net [mailto:graal-dev-bounces at openjdk.java.net] On Behalf Of Doug Simon
Sent: Tuesday, October 22, 2013 4:36 AM
To: Venkatachalam, Vasanth
Cc: graal-dev at openjdk.java.net
Subject: Re: hsail test case failures in the latest tip

As indicated by the exceptions raised by these tests (e.g., below), you need to fix the incomplete/incorrect HSAILLIRGenerator and HSAILHotSpotForeignCallsProvider classes.

-Doug

1) test(com.oracle.graal.compiler.hsail.test.StaticNBodyCallTest)
com.oracle.graal.graph.GraalInternalError: unimplemented
	at node: 504|Invoke#Direct#sqrt
	at com.oracle.graal.graph.GraalInternalError.unimplemented(GraalInternalError.java:38)
	at com.oracle.graal.compiler.hsail.HSAILLIRGenerator.emitDirectCall(HSAILLIRGenerator.java:553)
	at com.oracle.graal.compiler.gen.LIRGenerator.emitInvoke(LIRGenerator.java:579)
	at com.oracle.graal.nodes.InvokeWithExceptionNode.generate(InvokeWithExceptionNode.java:137)
	at com.oracle.graal.compiler.gen.LIRGenerator.emitNode(LIRGenerator.java:387)
	at com.oracle.graal.compiler.gen.LIRGenerator.doRoot(LIRGenerator.java:376)
	at com.oracle.graal.compiler.gen.LIRGenerator.doBlock(LIRGenerator.java:327)
	at com.oracle.graal.compiler.GraalCompiler$3.emitBlock(GraalCompiler.java:259)
	at com.oracle.graal.compiler.GraalCompiler$3.run(GraalCompiler.java:246)
	at com.oracle.graal.debug.internal.DebugScope.executeScope(DebugScope.java:258)
	at com.oracle.graal.debug.internal.DebugScope.scope(DebugScope.java:245)
	at com.oracle.graal.debug.Debug.scope(Debug.java:164)
	at com.oracle.graal.debug.Debug.scope(Debug.java:159)
	at com.oracle.graal.compiler.GraalCompiler.emitLIR(GraalCompiler.java:242)
	at com.oracle.graal.compiler.GraalCompiler$1$2.call(GraalCompiler.java:154)
	at com.oracle.graal.compiler.GraalCompiler$1$2.call(GraalCompiler.java:1)
	at com.oracle.graal.debug.internal.DebugScope.call(DebugScope.java:383)
        ...
2) test(com.oracle.graal.compiler.hsail.test.StringContainsAcceptTest)
com.oracle.graal.graph.GraalInternalError: unimplemented: createOutOfBoundsException(int)Object
	at node: 312|ForeignCall#createOutOfBoundsException(int)Object
	at com.oracle.graal.graph.GraalInternalError.unimplemented(GraalInternalError.java:42)
	at com.oracle.graal.hotspot.hsail.HSAILHotSpotForeignCallsProvider.lookupForeignCall(HSAILHotSpotForeignCallsProvider.java:52)
	at com.oracle.graal.nodes.extended.ForeignCallNode.generate(ForeignCallNode.java:82)
	at com.oracle.graal.compiler.gen.LIRGenerator.emitNode(LIRGenerator.java:387)
	at com.oracle.graal.compiler.gen.LIRGenerator.doRoot(LIRGenerator.java:376)
	at com.oracle.graal.compiler.gen.LIRGenerator.doBlock(LIRGenerator.java:327)
	at com.oracle.graal.compiler.GraalCompiler$3.emitBlock(GraalCompiler.java:259)
	at com.oracle.graal.compiler.GraalCompiler$3.run(GraalCompiler.java:246)
        ...

On Oct 22, 2013, at 5:02 AM, "Venkatachalam, Vasanth" <Vasanth.Venkatachalam at amd.com> wrote:

> Doug,
> 
> Please try running with -G:+InlineEverything  -G:-RemoveNeverExecutedCode 
> 
> Vasanth
> 
> -----Original Message-----
> From: Doug Simon [mailto:doug.simon at oracle.com] 
> Sent: Monday, October 21, 2013 1:16 PM
> To: Venkatachalam, Vasanth
> Cc: graal-dev at openjdk.java.net
> Subject: Re: hsail test case failures in the latest tip
> 
> Can you please tell me how to reproduce the failures. They passed the gate as seem to pass when I run them locally:
> 
> $ mx --vm server unittest StaticNBodyCallTest StringContainsAcceptTest executing junit tests now... (2 test classes) JUnit version 4.8 ..
> Time: 0.009
> 
> OK (2 tests)
> 
> -Doug
> 
> On Oct 21, 2013, at 7:21 PM, "Venkatachalam, Vasanth" <Vasanth.Venkatachalam at amd.com> wrote:
> 
>> Doug-
>> 
>> There are a couple of HSAIL test cases that are failing on the latest tip, namely hsail.test.StaticNBodyCallTest and hsail.test.StringContainsAcceptTest.
>> These test cases were passing as of rev 12895, which was uploaded around a week before the refactoring changes that you checked in.
>> 
>> Can you examine which got checked in that's causing these tests to fail?
>> 
>> Vasanth
>> 
>> 
>> 
> 
> 
>