Code must (soon) comply with Eclipse formatting command

Bernhard Urban bernhard.urban at jku.at
Wed Oct 30 02:11:00 PDT 2013


Tom,

thanks for your notice.  We do not enforce the eclipse formatter in our 
gate yet, so this was able to sneak through it.


-Bernhard

On 10/29/2013 11:56 PM, Deneau, Tom wrote:
> Doug --
>
> I noticed that
>
>     graal/com.oracle.graal.replacements/src/com/oracle/graal/replacements/SnippetCounter.java
>
> from the trunk gets slightly modified by the command below.
>
> -- Tom
>
> -----Original Message-----
> From: graal-dev-bounces at openjdk.java.net [mailto:graal-dev-bounces at openjdk.java.net] On Behalf Of Doug Simon
> Sent: Monday, October 21, 2013 1:27 PM
> To: graal-dev at openjdk.java.net
> Subject: Code must (soon) comply with Eclipse formatting command
>
> The bugs preventing the Eclipse formatter from being used from the command line seem to have been fixed as of Eclipse 4.3[1]. As such, we will soon add a check in the gate that all incoming code is formatted according to this tool. If you are using Eclipse for development, this should not be a problem. If not, you should run the following before trying to push or submit a webrev:
>
> $ mx eclipseformat -e /path/to/eclipse4.3installation
>
> If this command reports that 0 files were modified, your changes should get through (this part of) the gate.
>
> -Doug
>
> [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=405338
>
>



More information about the graal-dev mailing list