hsail lambda-based junits

Doug Simon doug.simon at oracle.com
Sun Apr 13 21:43:09 UTC 2014

Hi Tom,

I’ve integrated this with the following changes:

o Fixed formatting issue found by ‘mx eclipseformat’. Please run ‘mx gate -n -j’ on your workspace before submitting a patch. Now that it’s possible to use Eclipse + Java8, there is another easy way to meet the code format requirements.
o Removed the dependency on commons-lang3-3.1.jar as only one method in the library was used (StringUtils.countMatches) and reproducing it in StringUtilsCountMatchesTest was easy enough.
o Commented out a few calls to System.out.println. Please try to keep the unit tests as silent as possible.


On Apr 12, 2014, at 1:18 AM, Deneau, Tom <tom.deneau at amd.com> wrote:

> One last webrev for this week...
> http://cr.openjdk.java.net/~tdeneau/graal-webrevs/webrev-hsail-lambda-junits/webrev/
> Background...
> We had originally designed the graal hsail junit infrastructure to support both java 7 methods and java 8 lambdas.  It was actually a little easier to produce tests in the lambda format and we often did that.  But when we started pushing tests out to the graal trunk, we learned that the lambda tests that required java 8 would have to wait until eclipse supported java 8.
> In our local repo we kept those in a separate project which @javaCompliance=1.8.   If we really wanted a junit test in trunk, we ported it from java 8 style to java 7 style.  But some tests never got ported.
> Anyway, now that graal fully supports java 8, we would like to push these lambda based tests.   Since we don't need a separate project, I just put them as a separate package in the com.oracle.graal.hsail.compiler.test project.
> The webrev also includes some minor tidying up of the non-lambda based junits.
> -- Tom

More information about the graal-dev mailing list